Align byte units to tectonic ones. #338
Conversation
Pull Request Test Coverage Report for Build 1127
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1354
💛 - Coveralls |
|
Hey @rawagner! Thanks and acknowledged :) |
| }); | ||
| it('formats cores', () => { | ||
| expect(formatCores(2)).toEqual({ value: 2, unit: 'cores' }); | ||
| }); | ||
| it('formats net traffic', () => { | ||
| expect(formatNetTraffic(3 * 1024 * 1024)).toEqual({ value: 3, unit: 'MiBps' }); | ||
| expect(formatNetTraffic(3 * 1000 * 1000)).toEqual({ value: 3, unit: 'MBps' }); |
There was a problem hiding this comment.
why do we show the network in MBps instead of MiBps?
There was a problem hiding this comment.
@suomiy The last time I fell into this rabbit hole (a few months ago) I learned that networking metrics are still generally measured in Mbps (Megabits per second, note the lowercase b) largely because it has long-been the convention that "everyone" uses, even in cloud-oriented consoles where they use *iB units for everything else.
It's not the greatest reason, but it is what users currently expect for networking as far as I know. I personally can't remember ever seeing Mibps used elsewhere, but I'd be happy to be wrong.
There was a problem hiding this comment.
The last time I fell into this rabbit hole (a few months ago) I learned that networking metrics are still generally measured in Mbps (Megabits per second, note the lowercase b) largely because it has long-been the convention that "everyone" uses, even in cloud-oriented consoles where they use *iB units for everything else.
Ok then. If it was decided like that.
I personally can't remember ever seeing Mibps used elsewhere, but I'd be happy to be wrong.
A lot of software uses IEC binary units (KiB/s, MiB/s), e.g. curl, torrent clients.
There was a problem hiding this comment.
Good to know! As a relative outsider I like KiB/s and MiB/s and would be happy to switch to that if users find it natural. Looking at what OKD and the Prometheus Dashboard currently do, it seems like they're using Kbps, right? They're a little ambiguous.
There was a problem hiding this comment.
to me it seems that Prometheus dashboard uses kB/s (kBps)
@AyushAmbastha changing storage units to tectonic ones as suggested by @andybraren in #318 (comment) and network to MBps format