-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
Pull Request Test Coverage Report for Build 1336
💛 - Coveralls |
<DashboardCardTitle>Events</DashboardCardTitle> | ||
<DashboardCardTitleHelp>help for events</DashboardCardTitleHelp> | ||
</DashboardCardHeader> | ||
<DashboardCardBody id="events-body" className="kubevirt-events__body"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move body to Dashboard
folder (it would contain div
with id
and className
of DashboardCardBody) so it can be reused here and in cluster overview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawagner Ahh missed your comment and did it differently. Directly used Cardbody and passed just the ID. please check if that's ok otherwise we do it your way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also move events.scss
from ClusterOverview
to Dashboard
folder
import { CardBody } from 'patternfly-react'; | ||
|
||
const EventsBody = ({ children, ...props }) => ( | ||
<CardBody {...props} className="kubevirt-events__body"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CardBody
is already used in DashboardCardBody
so I would use simple div
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawagner I tried using div and it's not working. It expects class cardBody's class to be in same div.
If it's coming like this[1] then its working. but when using div the card-pf-body
is a parent at that point it's not working.
-
<div id="events-body" class="card-pf-body kubevirt-events__body" style="position: relative;">
<div class="card-pf-body>
<div id="events-body" class="card-pf-body kubevirt-events__body" style="position: relative;">
</div>
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloudbehl I tried it and found the issue
- div in EventsBody
<div id="events-body" className="kubevirt-events__body">
{children}
</div>
.kubevirt-events__body
css style needs to have fixed heightheight: 400px
instead of currently usedmax-height
. Also it would be good to changemargin
tomargin: -15px -15px;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawagner Ack, will make the change and I will update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawagner I provided the min-height and the max-height. Instead of just passing the height.
If there is only one Event in the box then we will show to the our min-height. Does it sounds good?
Also due to the margin change the processing/loaded icon is going out of context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I will fix the loading state in followup PR
72f0113
to
4af3781
Compare
ref: kubevirt/web-ui#275