Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Added events card #324

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Added events card #324

merged 1 commit into from
Apr 10, 2019

Conversation

cloudbehl
Copy link
Contributor

@cloudbehl cloudbehl commented Apr 8, 2019

@coveralls
Copy link

coveralls commented Apr 8, 2019

Pull Request Test Coverage Report for Build 1336

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 87.32%

Totals Coverage Status
Change from base Build 1328: 0.04%
Covered Lines: 3216
Relevant Lines: 3530

💛 - Coveralls

<DashboardCardTitle>Events</DashboardCardTitle>
<DashboardCardTitleHelp>help for events</DashboardCardTitleHelp>
</DashboardCardHeader>
<DashboardCardBody id="events-body" className="kubevirt-events__body">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move body to Dashboard folder (it would contain div with id and className of DashboardCardBody) so it can be reused here and in cluster overview.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawagner Ahh missed your comment and did it differently. Directly used Cardbody and passed just the ID. please check if that's ok otherwise we do it your way.

Copy link
Contributor

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also move events.scss from ClusterOverview to Dashboard folder

import { CardBody } from 'patternfly-react';

const EventsBody = ({ children, ...props }) => (
<CardBody {...props} className="kubevirt-events__body">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CardBody is already used in DashboardCardBody so I would use simple div here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawagner I tried using div and it's not working. It expects class cardBody's class to be in same div.

If it's coming like this[1] then its working. but when using div the card-pf-body is a parent at that point it's not working.

  1. <div id="events-body" class="card-pf-body kubevirt-events__body" style="position: relative;">

<div class="card-pf-body>
    <div id="events-body" class="card-pf-body kubevirt-events__body" style="position: relative;"> 
    </div>
</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloudbehl I tried it and found the issue

  1. div in EventsBody
<div id="events-body" className="kubevirt-events__body">
    {children}
  </div>
  1. .kubevirt-events__body css style needs to have fixed height height: 400px instead of currently used max-height. Also it would be good to change margin to margin: -15px -15px;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawagner Ack, will make the change and I will update the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawagner I provided the min-height and the max-height. Instead of just passing the height.
If there is only one Event in the box then we will show to the our min-height. Does it sounds good?

Also due to the margin change the processing/loaded icon is going out of context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I will fix the loading state in followup PR

@cloudbehl cloudbehl force-pushed the events branch 4 times, most recently from 72f0113 to 4af3781 Compare April 9, 2019 18:55
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2019
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2019
@rawagner rawagner merged commit 1d43de0 into kubevirt:master Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants