pkg/virtctl/version: code cleanups and refactoring (#14085)

[salawhaaat]

What this PR does

Before this PR:

• virtctl version command contained unnecessary complexity.
• Used fmt.Sprintf("%#v", value) redundantly.
• Error handling could be improved for better debugging.
• Used cobra.ExactArgs(0) instead of cobra.NoArgs.

After this PR:

• Refactored usage() to use a multiline string for better readability.
• Improved error handling using fmt.Errorf("%w", err) for better error wrapping.
• Used cobra.NoArgs for idiomatic Go practices.
• Removed unnecessary fmt.Sprintf("%#v", value) calls in printf.
• Applied early return pattern to simplify the Run() function.

Fixes #14085

Why we need it and why it was done in this way

The following tradeoffs were made:

• Improved code maintainability and readability without changing functionality.
• Focused on Go best practices to align with idiomatic coding styles.

The following alternatives were considered:

• Keeping the existing code but it was less readable.
• Introducing a larger refactor, but that would be out of scope.

Links to places where the discussion took place: #14085

Special notes for your reviewer

• Focus on readability improvements.
• Ensure error wrapping changes align with best practices.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note

NONE

[kubevirt-bot]

Hi @salawhaaat. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[0xFelix]

Awesome, I have only two nits. Please address them and mark the PR ready for review/testing after.

[salawhaaat]

Awesome, I have only two nits. Please address them and mark the PR ready for review/testing after.

Sweet, done. Thank you for quick response.

[mohit-nagaraj]

Looks good! 🙌
Could you also please rebase commits into a single commit for a cleaner git history as preferred! Thanks :)

[0xFelix]

/test all

[0xFelix]

Looks like you need to run make format and amend the changes to your commit.

[salawhaaat]

Looks like you need to run make format and amend the changes to your commit.

thx, i will try 👍

[salawhaaat]

/retest

[kubevirt-bot]

@salawhaaat: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[salawhaaat]

/test all

[kubevirt-bot]

@salawhaaat: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[salawhaaat]

@0xFelix I am very sorry that it took long. The reason behind that, I couldn't start make process without docker, since I had docker issue.

[0xFelix]

No worries

/test all

[victortoso]

Tests are happy too.
/lgtm

[0xFelix]

/approve

Thank you very much @salawhaaat

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/virtctl/OWNERS [0xFelix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-commenter-bot]

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.30-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.32-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/test pull-kubevirt-e2e-k8s-1.31-sig-operator

[salawhaaat]

/approve

Thank you very much @salawhaaat

Yeaaaah, let's goo. I will be happy to continue on next open task.