Skip to content

fix: revert "fix: update rbac proxy image to address cve" #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ed382
Copy link
Contributor

@ed382 ed382 commented Jan 14, 2025

This reverts commit 0cfa37b.

Pull request description

causes exception:

Defaulted container "kube-rbac-proxy" out of: kube-rbac-proxy, manager
panic: version string "" doesn't match expected regular expression: "^v(\d+\.\d+\.\d+)"

goroutine 1 [running]:
k8s.io/component-base/metrics.parseVersion({{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, {0x1c55f00, 0x28}, {0x0, 0x0}, ...})
        /home/runner/go/pkg/mod/k8s.io/[email protected]/metrics/version_parser.go:47 +0x1b4
k8s.io/component-base/metrics.newKubeRegistry({{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0}, {0x1c55f00, 0x28}, {0x0, 0x0}, ...})
        /home/runner/go/pkg/mod/k8s.io/[email protected]/metrics/registry.go:371 +0xec
k8s.io/component-base/metrics.NewKubeRegistry()
        /home/runner/go/pkg/mod/k8s.io/[email protected]/metrics/registry.go:385 +0x6c
k8s.io/component-base/metrics/legacyregistry.init()
        /home/runner/go/pkg/mod/k8s.io/[email protected]/metrics/legacyregistry/registry.go:31 +0x1c

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@ed382 ed382 self-assigned this Jan 14, 2025
@ed382 ed382 requested a review from a team as a code owner January 14, 2025 15:52
@ed382 ed382 merged commit 84684a8 into main Jan 14, 2025
3 of 4 checks passed
@ed382 ed382 deleted the revert-rbac-image branch January 14, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant