Skip to content

fix: add missing property in the testkube umbrella chart #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

caiomede-tk
Copy link
Contributor

Pull request description

Testkube chart was missing a property in its values.yaml file that allow users to install agent using an existing secret to manage key, orgId, and envId param needed to connect agent with a Control Plane.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

  • Add existingSecret property from testkube-api into the umbrella chart values.yaml file.

@caiomede-tk caiomede-tk requested a review from a team as a code owner March 11, 2025 13:26
@olensmar
Copy link
Member

should this be added to docs also?

@caiomede-tk caiomede-tk merged commit 62a2c30 into main Mar 11, 2025
3 checks passed
@caiomede-tk caiomede-tk deleted the feature/add-existing-secret-in-umbrella-chart branch March 11, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants