Skip to content

Improve landing pages for user stories #9230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2018
Merged

Improve landing pages for user stories #9230

merged 1 commit into from
Jun 27, 2018

Conversation

lucperkins
Copy link
Contributor

In issue #9229 I was made aware that the landing pages for user stories (application developer and cluster operator) bring up big error messages. This PR fixes that by providing a various basic, non-broken page.

This is not a huge priority given that there are no direct links to those landing pages in the docs but better not to make readers confront errors.

@lucperkins lucperkins requested a review from zacharysarah June 25, 2018 21:29
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8a9923e

https://deploy-preview-9230--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 25, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8e476e1

https://deploy-preview-9230--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor

zacharysarah commented Jun 26, 2018 •
edited
Loading

My own preference is for redirects instead of unlinked index files, but I would love to hear your thoughts, @steveperry-53.

@steveperry-53
Copy link
Contributor

@lucperkins, @zacharysarah I commented in #9229. Let's investigate a bit before we take action here.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2018
@lucperkins
Copy link
Contributor Author

lucperkins commented Jun 27, 2018 •
edited
Loading

@steveperry-53 @zacharysarah The solution I've currently opted for is to simply remove those pages. I ran a basic grep to double check and there are no links in the docs to /docs/user-journeys, /docs/user-journeys/users, /docs/user-journeys/users/cluster-operator, or /docs/user-journeys/users/application-developer. That is, all links are only to the specific user stories (e.g. /docs/user-journeys/users/application-developer/foundational).

The specific user story pages are, as you can see, unaffected:

@steveperry-53
Copy link
Contributor

/assign
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit e091e29 into kubernetes:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@steveperry-53 steveperry-53

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucperkins @k8sio-netlify-preview-bot @zacharysarah @steveperry-53 @k8s-ci-robot