Skip to content

[KEP-5075] DRAConsumableCapacity documentation #51479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev-1.34
Choose a base branch
from
Open

[KEP-5075] DRAConsumableCapacity documentation #51479

wants to merge 1 commit into from
+106 −0

Conversation

sunya-ch
Copy link

@sunya-ch sunya-ch commented Jul 2, 2025

Description

Docs change for KEP-5075.

Issue

kubernetes/enhancements: kubernetes/enhancements#5075
kubernetes/kubernetes: kubernetes/kubernetes#132522

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sunya-ch!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from natalisucks and pohly July 2, 2025 14:13
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2025
@sunya-ch sunya-ch mentioned this pull request Jun 27, 2025
Open
4 tasks
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 2, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 38c660a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6865bb48bcc6ef0008239710
😎 Deploy Preview https://deploy-preview-51479--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lmktfy
lmktfy reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I think this should target the dev-1.34 branch.
Does that sound right?

OK to unhold once target branch is confirmed.

content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated
capacity:
bandwidth:
sharingPolicy:
default: "1Mi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd to use mebi- for network bandwidth. Maybe use mega- ?

content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated
device.allowMultipleAllocations == true
capacityRequests:
minimum:
bandwidth: 5Gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably mean 5G here.

content/en/docs/concepts/scheduling-eviction/dynamic-resource-allocation.md Outdated
devices:
results:
- consumedCapacities:
bandwidth: 5Gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably mean 5G here. Although, to avoid confusion with 5G as in mobile packet data, consider using different fractions.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@sunya-ch sunya-ch changed the base branch from main to dev-1.34 July 2, 2025 23:05
@sunya-ch
Copy link
Author

sunya-ch commented Jul 2, 2025

@lmktfy Thank you so much for the review. I have rebased to dev-1.34 and committed your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmktfy lmktfy lmktfy left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunya-ch @k8s-ci-robot @lmktfy