Skip to content

Fix typo in Horizontal Pod Autoscaling. #31668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

Fix typo in Horizontal Pod Autoscaling. #31668

merged 2 commits into from
Feb 11, 2022

Conversation

Shubham82
Copy link
Contributor

This PR fixes the minor typo in Horizontal Pod Autoscaling i.e. add on should be addon

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Feb 9, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 9, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 9, 2022
@Shubham82
Copy link
Contributor Author

Hi @DirectXMan12 @kbhawkey
Could you please take a look!

@netlify
Copy link

netlify bot commented Feb 9, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 929e8a2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6206818fb5233f0008a90d5d

😎 Browse the preview: https://deploy-preview-31668--kubernetes-io-main-staging.netlify.app

Arhell
Arhell reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign CLA
#31668 (comment)
for check /check-cla

@divya-mohan0209
Copy link
Contributor

Hello @Shubham82 , thank you for the PR. Please could you sign the easy CLA as indicated by the bot above?

@Shubham82
Copy link
Contributor Author

Hi @Arhell @divya-mohan0209
I already signed the CLA, I think EasyCLA is now compulsory in Kubernetes/website. Am i right?
I will resolve this soon.
thanks

@sftim
Copy link
Contributor

sftim commented Feb 9, 2022

EasyCLA is now compulsory.
/easycla

@sftim
Copy link
Contributor

sftim commented Feb 9, 2022

We can check whether your existing CLA should apply - maybe there is an EasyCLA bug.

@Shubham82
Copy link
Contributor Author

Thanks, @sftim for taking look at this.

@Shubham82
Copy link
Contributor Author

@sftim I also raised this concern in EasyCLA Feedback & Issues#1021056438 but not get any response till now.

@WillsonHG
Copy link

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 9, 2022
@Shubham82
Copy link
Contributor Author

Hi @Arhell @divya-mohan0209
The EasyCLA error is resolved now for this PR, so could please take a look!

Thanks

sftim
sftim reviewed Feb 11, 2022
View reviewed changes
content/en/docs/tasks/run-application/horizontal-pod-autoscale.md Outdated
@@ -88,7 +88,7 @@ or the custom metrics API (for all other metrics).
The common use for HorizontalPodAutoscaler is to configure it to fetch metrics from
{{< glossary_tooltip text="aggregated APIs" term_id="aggregation-layer" >}}
(`metrics.k8s.io`, `custom.metrics.k8s.io`, or `external.metrics.k8s.io`). The `metrics.k8s.io` API is
usually provided by an add on named Metrics Server, which needs to be launched separately.
usually provided by an addon named Metrics Server, which needs to be launched separately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the glossary, “add-on” is idiomatic:

Suggested change
usually provided by an addon named Metrics Server, which needs to be launched separately.
usually provided by an add-on named Metrics Server, which needs to be launched separately.

Please also consider the policy on trivial edits @Shubham82.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sftim thanks for it.
Sure, I will fix the other typos in this document, Also I will update the addon to add-on mentioned in HPA docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sftim
I have Addressed the comment, and fixed a few other typos in the hpa docs, PTAL!

Thanks

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbfef17cb27fe77c1e6c43f04eec3743f1130e43

sftim
sftim reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 108bae8 into kubernetes:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@Arhell Arhell Arhell left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Shubham82 @divya-mohan0209 @sftim @WillsonHG @reylejano @k8s-ci-robot @Arhell