Skip to content

Improve documentation for container probes #30710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

Improve documentation for container probes #30710

merged 1 commit into from
Dec 3, 2021

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 1, 2021 •
edited
Loading

/sig node
/milestone 1.23

Related PRs:

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 1, 2021
@netlify
Copy link

netlify bot commented Dec 1, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 8a0f330

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61a9643b12d55900070d4dc5

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 1, 2021
@jlbutler
Copy link
Contributor

jlbutler commented Dec 2, 2021

/assign

@sftim sftim force-pushed the 20211201_improve_probe_documentation branch 4 times, most recently from 46d956d to 6bef889 Compare December 2, 2021 17:39
@sftim sftim marked this pull request as ready for review December 2, 2021 17:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2021
@sftim sftim force-pushed the 20211201_improve_probe_documentation branch from 6bef889 to 6d33912 Compare December 2, 2021 17:41
@sftim
Copy link
Contributor Author

sftim commented Dec 3, 2021

Slightly related to kubernetes/kubernetes#106774 but not essential as part of that fix.

@sftim sftim force-pushed the 20211201_improve_probe_documentation branch from 6d33912 to dab6c59 Compare December 3, 2021 00:24
Improve documentation for container probes
8a0f330 
- mention gRPC probes in concept page
- revise explanation of gRPC probes in task page
- general tidying
@sftim sftim force-pushed the 20211201_improve_probe_documentation branch from dab6c59 to 8a0f330 Compare December 3, 2021 00:26
@jlbutler
Copy link
Contributor

jlbutler commented Dec 3, 2021

@SergeyKanzhelev can you give this a quick tech review?

SergeyKanzhelev
SergeyKanzhelev approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9dc90f5e9d9a81fb6f67e1088333f1432ca39914

@jlbutler
Copy link
Contributor

jlbutler commented Dec 3, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlbutler, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4f193fe into kubernetes:dev-1.23 Dec 3, 2021
@sftim sftim deleted the 20211201_improve_probe_documentation branch December 8, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@jlbutler jlbutler

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @jlbutler @k8s-ci-robot @SergeyKanzhelev