Skip to content

Update 'Quantity' glossary definition to explain acronym SI #30504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

wiggitywhitney
Copy link

ʕु•̫͡•ʔु ✧ Greetings!

During my studies the 'Quantity' glossary definition confused me because I did not know what the acronym 'SI' meant. This PR updates the definition to explain what the acronym 'SI' means.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 16, 2021

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 16, 2021
@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 93df00a

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6194f155499fee000750dc20

😎 Browse the preview: https://deploy-preview-30504--kubernetes-io-main-staging.netlify.app

sftim
sftim previously requested changes Nov 16, 2021
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a hyperlink on line 18:

whole-number notation with SI suffixes. Fractional numbers are represented

with the link pointing to https://en.wikipedia.org/wiki/International_System_of_Units

The rest of this feedback is optional to implement.


You can also link “binary units” (or “binary suffixes”) to https://en.wikipedia.org/wiki/Binary_prefix (and I would do so)

Aside: this page uses the term “unit” where SI uses the term “prefix”.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language language/zh Issues or PRs related to Chinese language and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2021
@wiggitywhitney
Copy link
Author

Sorry for the messy commit history, I am learning Git.
ಠ~ಠ

@sftim
Copy link
Contributor

sftim commented Nov 16, 2021

@wiggitywhitney if you learn how to squash down to 1 commit: great. If not (or not yet):
/label tide/merge-method-squash

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiggitywhitney it looks like you have left in some unrelated changes and possibly undone some of the changes you did want to make.

If you're new to Git, the easiest thing to do is to start a brand new pull request where you make the equivalent changes, and then close this one.

/hold
as we shouldn't merge this as it stands

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2021
@wiggitywhitney
Copy link
Author

@sftim I made the changes as requested and fixed the messy commit history. I think this should be g2g.
(^-^)/ Huzzah!

@divya-mohan0209
Copy link
Contributor

@wiggitywhitney : Please could you squash & merge the commits into one (keeping only the latest changes, of course)?

@wiggitywhitney
Copy link
Author

@divya-mohan0209 It is done! (^-^)/

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Nice improvement

/lgtm
/approve

@sftim sftim dismissed their stale review November 17, 2021 12:27

All dealth with

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fdbeb3f82b552b0d3e2cf82b2a01facabee37d42

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@sftim
Copy link
Contributor

sftim commented Nov 17, 2021

/remove-language zh
/remove-language id

@k8s-ci-robot k8s-ci-robot merged commit d54f091 into kubernetes:main Nov 17, 2021
@k8s-ci-robot k8s-ci-robot removed language/zh Issues or PRs related to Chinese language language/id Issues or PRs related to Indonesian language labels Nov 17, 2021
@wiggitywhitney wiggitywhitney deleted the quantity-glossary-si branch November 17, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants