-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Update 'Quantity' glossary definition to explain acronym SI #30504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'Quantity' glossary definition to explain acronym SI #30504
Conversation
|
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 93df00a 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6194f155499fee000750dc20 😎 Browse the preview: https://deploy-preview-30504--kubernetes-io-main-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a hyperlink on line 18:
whole-number notation with SI suffixes. Fractional numbers are represented
with the link pointing to https://en.wikipedia.org/wiki/International_System_of_Units
The rest of this feedback is optional to implement.
You can also link “binary units” (or “binary suffixes”) to https://en.wikipedia.org/wiki/Binary_prefix (and I would do so)
Aside: this page uses the term “unit” where SI uses the term “prefix”.
Sorry for the messy commit history, I am learning Git. |
@wiggitywhitney if you learn how to squash down to 1 commit: great. If not (or not yet): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wiggitywhitney it looks like you have left in some unrelated changes and possibly undone some of the changes you did want to make.
If you're new to Git, the easiest thing to do is to start a brand new pull request where you make the equivalent changes, and then close this one.
/hold
as we shouldn't merge this as it stands
9a1854c
to
4475fb3
Compare
@sftim I made the changes as requested and fixed the messy commit history. I think this should be g2g. |
@wiggitywhitney : Please could you squash & merge the commits into one (keeping only the latest changes, of course)? |
1c9eb3b
to
93df00a
Compare
@divya-mohan0209 It is done! (^-^)/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Nice improvement
/lgtm
/approve
LGTM label has been added. Git tree hash: fdbeb3f82b552b0d3e2cf82b2a01facabee37d42
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-language zh |
ʕु•̫͡•ʔु ✧ Greetings!
During my studies the 'Quantity' glossary definition confused me because I did not know what the acronym 'SI' meant. This PR updates the definition to explain what the acronym 'SI' means.