Skip to content

Divided headings: labels, annotations, taints #29685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

itsguneetsingh
Copy link
Contributor

Made two separate headings as asked for in the issue #29670 and wrote some additional text under each heading explaining

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @Guneetconvent2002!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 13, 2021
@itsguneetsingh
Copy link
Contributor Author

signed the CLA

@geoffcline
Copy link
Contributor

/check-cla

@geoffcline
Copy link
Contributor

Hi @Guneetconvent2002 and welcome 👋

It seems your CLA still isn't detected. Can you check that the email address used for these commits (git log) and the CLA membership match?

@geoffcline
Copy link
Contributor

also I'm going to /assign and suggest some revisions

@itsguneetsingh
Copy link
Contributor Author

Hi @Guneetconvent2002 and welcome 👋

It seems your CLA still isn't detected. Can you check that the email address used for these commits (git log) and the CLA membership match?

That's strange cause I have made a CLA profile and it uses the same email ID as on my github

@itsguneetsingh
Copy link
Contributor Author

also I'm going to /assign and suggest some revisions

do you mean that you're going to take over the issue or give me some suggestions to make changes??

@itsguneetsingh
Copy link
Contributor Author

Could you maybe help me cause I have the same email ID for both git commit and EasyCLA

image
image

@geoffcline
Copy link
Contributor

Yes, ill review and suggest changes. I'll also take a look at the CLA.

Copy link
Contributor

@geoffcline geoffcline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some changes. Overall, I think it's helpful to add a link here.

You can submit a support request regarding the CLA here: https://jira.linuxfoundation.org/plugins/servlet/theme/portal/4/create/88

@jlbutler
Copy link
Contributor

/assign

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 15, 2021
@netlify
Copy link

netlify bot commented Sep 17, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 4a7a977

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61a7fb2cee2e8a0008bf5e4e

@itsguneetsingh
Copy link
Contributor Author

@jlbutler could maybe have a look on this and tell me what changes to make?

@jlbutler
Copy link
Contributor

@jlbutler could maybe have a look on this and tell me what changes to make?

Hi there! 👋 For your commits, avoid using @'s (as well as # references) in the commit message. As you're working through your edits, you may consider rebasing and collapsing into a single commit (though not necessary right now).

For the content, @gcilne can you spin back through and review edits so far?

Thanks everyone!

@itsguneetsingh
Copy link
Contributor Author

@jlbutler could maybe have a look on this and tell me what changes to make?

Hi there! 👋 For your commits, avoid using @'s (as well as # references) in the commit message. As you're working through your edits, you may consider rebasing and collapsing into a single commit (though not necessary right now).

For the content, @gcilne can you spin back through and review edits so far?

Thanks everyone!

Okay, I'll keep in mind in the future. I don't think that I need to undo that commit now. do I?
Also, It's been a week and I have no response regrading any changes to be made so, if you or @geoffcline could look at this and let me know what needs to be done or taken care of?


The Seccomp annotation has been deprecated since Kubernetes v1.19 and will become non-functional in v1.25.
`seccomp` is now a class inside of the pod or container. This can be changed by using `type` of the `seccompProfile` of the `securityContext`. For additinal info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revise this sentence based on this section of the style guide?

@geoffcline
Copy link
Contributor

Just two small changes suggested 👍

@itsguneetsingh
Copy link
Contributor Author

I have implemented the changes that you asked for @geoffcline
Hope it's fine now. Also, do I need to delete the commit mentioning you? cause the bot has reacted on it multiple times. If yes, then could you maybe tell me how I could do it?

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13dcc8f903cc9e9d0e43729d05aff410cd253545

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Guneetconvent2002

Thanks for these changes @Guneetconvent2002

/lgtm
I think these are technically correct and (barely) OK to merge.
The proposed text links to https://k8s.io//docs/reference/generated/kubernetes-api/v1.22/#podsecuritycontext-v1-core
which:

  • will go stale when Kubernetes v1.23 is released
  • is a link to our old API reference, not the preferred current one

@Guneetconvent2002 If you want to, I think we could improve this documentation further and I have made some suggestions based on how I'd write these.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2021
@sftim
Copy link
Contributor

sftim commented Oct 19, 2021

Hi @Guneetconvent2002

Could you squash this down to 1 commit? (If you're not sure how, you can instead let us know that you agree and a maintainer can do the squash for you).

@itsguneetsingh
Copy link
Contributor Author

I don't really know how to squash commits together so, if a maintainer could do it, that would be great.

@geoffcline
Copy link
Contributor

/label tide/merge-method-squash
/lgtm

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 12, 2021
@geoffcline
Copy link
Contributor

ok, now it will be automatically squashed when approved :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ccc727cd56f6962de01118ae4e351760fdc5c48

@jlbutler
Copy link
Contributor

@Guneetconvent2002 I'd pinged on this earlier, still unsure if this PR needs to come into dev-1.23 or main. If there isn't anything specific to the 1.23 release (or later), this PR can point at main.

@itsguneetsingh
Copy link
Contributor Author

When I started working on this, the query mentioned that changes were required in dev-1.23 specifically. Since the topics where I've made changes; I was not able to find them in the main branch when I was trying to do so

@reylejano
Copy link
Member

@Guneetconvent2002 can you squash your commits. One of your commit messages uses an invalid character #

@itsguneetsingh
Copy link
Contributor Author

@Guneetconvent2002 can you squash your commits. One of your commit messages uses an invalid character #

I'm sorry but I don't really know how to do it. Perhaps if the admins could do it. @jlbutler could you maybe help me with that?

@jlbutler
Copy link
Contributor

jlbutler commented Dec 1, 2021

@Guneetconvent2002 i'll ping on slack again and see if we can work through it there.

@sftim
Copy link
Contributor

sftim commented Dec 1, 2021

I'll squash these down for you @Guneetconvent2002 using my maintainer access to write to your fork

Co-authored-by: Qiming Teng <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 1, 2021
@linux-foundation-easycla
Copy link

CLA Not Signed

@sftim
Copy link
Contributor

sftim commented Dec 1, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@sftim
Copy link
Contributor

sftim commented Dec 1, 2021

/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 1, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1922a3d into kubernetes:dev-1.23 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants