Skip to content

Drop explicit ClusterTrustBundle focus from alpha-only jobs #34470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 7, 2025

This is step 1 of transitioning ClusterTrustBundle from alpha to beta. Promotion from alpha to beta will turn these alpha-only jobs which explicitly focus on the ClusterTrustBundle tests red. It was questionable to structure these this way in the first place.

Step 2 will get these tests added to run in the kind-alpha / kind-alpha-beta jobs in a follow-up (will likely require both test-infra and k/k PRs).

Step 3 will promote CTB to beta and ensure that the tests run in the kind-alpha-beta / kind-beta jobs (will ideally only require a k/k PR).

cc @stlaz @pohly @aojea

context:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2025
@liggitt liggitt changed the title Drop ClusterTrustBundle focus from alpha-only jobs Drop explicit ClusterTrustBundle focus from alpha-only jobs Mar 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and cheftako March 7, 2025 16:45
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 7, 2025
@stlaz
Copy link
Member

stlaz commented Mar 7, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit a08f74d into kubernetes:master Mar 7, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key periodic-e2e.yaml using file config/jobs/kubernetes/sig-cloud-provider/periodic-e2e.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

This is step 1 of transitioning ClusterTrustBundle from alpha to beta. Promotion from alpha to beta will turn these alpha-only jobs which explicitly focus on the ClusterTrustBundle tests red. It was questionable to structure these this way in the first place.

Step 2 will get these tests added to run in the kind-alpha / kind-alpha-beta jobs in a follow-up (will likely require both test-infra and k/k PRs).

Step 3 will promote CTB to beta and ensure that the tests run in the kind-alpha-beta / kind-beta jobs (will ideally only require a k/k PR).

cc @stlaz @pohly @aojea

context:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants