Skip to content

always enable ClusterTrusbBundles feature gates in tests that both focus it and enable all alpha APIs #34451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −6
Closed

always enable ClusterTrusbBundles feature gates in tests that both focus it and enable all alpha APIs #34451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc4d924
gce-alpha-features: always enable ClusterTrusbBundles feature gates
stlaz Mar 4, 2025
f256324
add ClusterTrustBundles FGs to jobs that focus it and enable all alph…
stlaz Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ presubmits:
args:
- --ginkgo-parallel=1
- --build=quick
- --env=KUBE_FEATURE_GATES=AllAlpha=true,EventedPLEG=false
- --env=KUBE_FEATURE_GATES=AllAlpha=true,ClusterTrustBundle=true,ClusterTrustBundleProjection=true,EventedPLEG=false
- --env=ENABLE_CACHE_MUTATION_DETECTOR=true
- --env=KUBE_PROXY_DAEMONSET=true
- --env=ENABLE_POD_PRIORITY=true
Expand Down Expand Up @@ -933,7 +933,7 @@ periodics:
- /workspace/scenarios/kubernetes_e2e.py
args:
- --check-leaked-resources
- --env=KUBE_FEATURE_GATES=AllAlpha=true,EventedPLEG=false
- --env=KUBE_FEATURE_GATES=AllAlpha=true,ClusterTrustBundle=true,ClusterTrustBundleProjection=true,EventedPLEG=false
- --env=ENABLE_CACHE_MUTATION_DETECTOR=true
- --env=KUBE_PROXY_DAEMONSET=true
- --env=ENABLE_POD_PRIORITY=true
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-cloud-provider/periodic-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ periodics:
kubetest2 ec2 \
--stage https://dl.k8s.io/ci/fast/ \
--version $VERSION \
--feature-gates="AllAlpha=true,EventedPLEG=false" \
--feature-gates="AllAlpha=true,ClusterTrustBundle=true,ClusterTrustBundleProjection=true,EventedPLEG=false" \
--runtime-config="api/all=true" \
--up \
--down \
Expand Down
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@ presubmits:
kubetest2 ec2 \
--stage https://dl.k8s.io/ci/fast/ \
--version $VERSION \
--feature-gates="AllAlpha=true,EventedPLEG=false,StorageVersionAPI=true,APIServerIdentity=true" \
--feature-gates="AllAlpha=true,ClusterTrustBundle=true,ClusterTrustBundleProjection=true,EventedPLEG=false,StorageVersionAPI=true,APIServerIdentity=true" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead set skip-regex to have [Beta] as a comparable stopgap, combined with kubernetes/kubernetes#130567 ?
I don't think the intent should be to run these tests in the alpha job as a beta feature

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the [Alpha] or [Beta] tagging since that will change selection of existing tests using featuregates in ways I'm unsure of

Using generic "Feature:Alpha" and "Feature:Beta" is net-new more incremental step I could reason about better ... I opened https://github.com/kubernetes/test-infra/pull/34456/files to add those focus / skips to the generic jobs I could find that were currently explicitly referencing the ClusterTrustBundle feature as a way to straddle onto making kubernetes/kubernetes#130572 and kubernetes/kubernetes#130567 work without dropping test coverage

Copy link
Contributor

@pohly pohly Mar 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a standardized [Feature:Alpha] automatically as a bridge / stop-gap

We have that, just not for focus/skip. It was meant to be used with --label-filter. kubernetes/kubernetes#130580 (opened today as alternative to kubernetes/kubernetes#130567) makes it available also to jobs using focus/filter.

just finish switching to label filter for critical shared jobs and PSA the org about the action required to update any other jobs (and if nobody response then ... those jobs must not be maintained)

I'm arriving at a similar conclusion. I was even considering to convert critical jobs to --label-filter and then label feature-gate-only tests so that they run in unconverted jobs. If they then fail, job owners either (finally) take notice or they don't and we can consider deleting the jobs. But with kubernetes/kubernetes#130580 such unconverted jobs wouldn't break like that - or rather, not break at all.

This may be good (no breakage) and bad (they don't get updated and we continue to depend on regexp in those jobs).

--runtime-config="api/all=true" \
--up \
--down \
Expand Down
4 changes: 2 additions & 2 deletions releng/test_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ testSuites:
- --timeout=180m
- --env=KUBE_PROXY_DAEMONSET=true
- --env=ENABLE_POD_PRIORITY=true
- --env=KUBE_FEATURE_GATES=AllAlpha=true
- --env=KUBE_FEATURE_GATES=AllAlpha=true,ClusterTrustBundle=true,ClusterTrustBundleProjection=true
# Panic if anything mutates a shared informer cache
- --env=ENABLE_CACHE_MUTATION_DETECTOR=true
- --runtime-config=api/all=true
Expand All @@ -280,7 +280,7 @@ testSuites:
- --timeout=180m
- --env=KUBE_PROXY_DAEMONSET=true
- --env=ENABLE_POD_PRIORITY=true
- --env=KUBE_FEATURE_GATES=AllAlpha=true,EventedPLEG=false
- --env=KUBE_FEATURE_GATES=AllAlpha=true,EventedPLEG=false,ClusterTrustBundle=true,ClusterTrustBundleProjection=true
# Panic if anything mutates a shared informer cache
- --env=ENABLE_CACHE_MUTATION_DETECTOR=true
- --runtime-config=api/all=true
Expand Down