etcd: Build 3.5.3-0 image

[serathius]

/sig release
/kind bug

NONE

/assign @dims

[dims]

/approve
/lgtm

[dims]

cc @kubernetes/release-team

we'll need to treat this as an item for release. we can't be using 3.6.0-alpha.0 as it was before and we switch to 3.5.3 which was released this morning. (this is the one where several data corruption issues were fixed)

https://github.com/etcd-io/etcd/releases/tag/v3.5.3
etcd-io/etcd@v3.5.2...v3.5.3

NOTE: after we build an image with this PR, we will be updating https://github.com/kubernetes/kubernetes/blob/master/build/dependencies.yaml#L58 as well in a subsequent PR

[dims]

/priority critical-urgent

[dims]

/milestone v1.24

[dims]

/hold for release team

[justaugustus]

/lgtm
/approve
/hold cancel

[liggitt]

this is for tests only, right?

does kubeadm have a corresponding change to make to pick up 3.5.3? my read of

kubernetes/cmd/kubeadm/app/constants/constants.go

Lines 491 to 503 in 75e49ec

	SupportedEtcdVersion = map[uint8]string{
	13: "3.2.24",
	14: "3.3.10",
	15: "3.3.10",
	16: "3.3.17-0",
	17: "3.4.3-0",
	18: "3.4.3-0",
	19: "3.4.13-0",
	20: "3.4.13-0",
	21: "3.4.13-0",
	22: "3.5.1-0",
	23: "3.5.1-0",
	}

is that 1.22+ will use the known-bad 3.5.1 version by default

[dims]

@neolit123 can you please add a PR to bump kubeadm to 3.5.3? (see note from @liggitt above)

[liggitt]

I agree we should not be using 3.6.0-alpha.0 or 3.5.2 in this image. I don't have a clear understanding of how important it is to get this PR in for 1.24 if the cluster/images/etcd image is only being used in kube CI

[justaugustus]

/hold found some more things that need fixing...

[neolit123]

does kubeadm have a corresponding change to make to pick up 3.5.3? my read of

@neolit123 can you please add a PR to bump kubeadm to 3.5.3? (see note from @liggitt above)

yep, i can do that later today.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• build/OWNERS [dims,justaugustus]
• cluster/images/etcd/OWNERS [dims,serathius]
• test/conformance/image/OWNERS [dims]
• test/utils/image/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justaugustus]

not sure if you were referring to my comment about kubeadm, but I wasn't expecting that change in this PR... just noting the other in-repo use I knew of

@liggitt -- Nope, I noticed that we were not using the:

1. latest versions of the debian-base images --> cddd83c
2. golang version that was used in the etcd v3.5.3 release --> b0f3f01 (ref: https://github.com/etcd-io/etcd/blob/0452feec719fa8ad88ae343e66e9bb222965d75d/Makefile#L58)

/hold cancel
/lgtm

[justaugustus]

does kubeadm have a corresponding change to make to pick up 3.5.3? my read of

@neolit123 can you please add a PR to bump kubeadm to 3.5.3? (see note from @liggitt above)

yep, i can do that later today.

@dims @neolit123 -- Here's part of it: #109471 (not sure of the other kubeadm things that may need to happen elsewhere...)

[justaugustus]

cc: @kubernetes/release-team-leads

[neolit123]

@dims @neolit123 -- Here's part of it: #109471 (not sure of the other kubeadm things that may need to happen elsewhere...)

thanks for sending the PR!

[justaugustus]

thanks for sending the PR!

No worries! Just give me a heads-up if there's anything missing from it.
I did my best guesses on what needed to be bumped.

[justaugustus]

/test pull-kubernetes-conformance-kind-ga-only-parallel

[leilajal]

/triage accepted