Welcome kinder! #1446
Welcome kinder! #1446
Conversation
k8s-ci-robot
added
sig/cluster-lifecycle
There was a problem hiding this comment.
i think @fabriziopandini did great exposing the potential of the kind backend and this is a superior replacement for the kubeadm playground (vagrant).
it also follows an original suggestion from the #kind maintainers, where the backend should be vendored for complicated developer use cases.
waiting on feedback from the others.
thanks.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - [x] Add worker node | ||
| - [x] Add control plane node (and reconfigure load balancer) | ||
| - [x] Provide smoke test action | ||
| - [ ] Provide E2E run action(s) |
There was a problem hiding this comment.
some of these test things would be nice to consider doing in kubetest2, FWIW
There was a problem hiding this comment.
Agreed. The idea is to provide something to use to the developer, but use kubetest/kubetest2 behind the scenes (don't reinvent the wheel, only provide an UX wrapper)
But still need to investigate details
There was a problem hiding this comment.
awesome, yeah kubetest2 is also still extremely MVP and could be changed as necessary, if not even using the whole tool it would be good to take a look at sharing some of the effort around the packages for this kind of work 😅
| - [x] external etcd | ||
| - [x] kube-dns | ||
| - [x] Provide "topology aware" wrappers for `docker exec` and `docker cp` | ||
| - [x] Provide a way to add nodes to an existing cluster |
There was a problem hiding this comment.
after prototyping here this probably makes sense to try to add to kind eventually 😅, +1 to building under kinder
There was a problem hiding this comment.
Agreed. Contributing back to kind is definitely in the radar
| - [x] init and join with automatic copy certs | ||
| - [x] Provide pre built “developer” workflow for kubeadm upgrades | ||
| - [x] reset | ||
| - [x] Allow build of node-image variants |
There was a problem hiding this comment.
I would include adding additional debugging tools xref kubernetes-sigs/kind#339
| High level goals for kinder v0.1 include: | ||
|
|
||
| - [ ] Provide a local test environment for kubeadm development | ||
| - [x] Allow creation of nodes "ready for installing Kubernetes" |
There was a problem hiding this comment.
this one / phases will also hopefully land upstream O(soon), been prototyping various options for this in kind 😅
There was a problem hiding this comment.
Great! I'm happy to nuke this in kinder as soon as possible!
|
|
||
| ### kinder cp | ||
|
|
||
| `kinder cp` provide a topology aware wrapper on docker `docker cp` . Following feature are supported: |
There was a problem hiding this comment.
some variant of this would also be pretty sweet upstream, but I'm generally +1 on develop ASAP here for kubeadm testing and filter back something like it based on what we learn from usage, if you're up for that 😅
There was a problem hiding this comment.
I'm definitely up for that!
| - [x] join and join with phases | ||
| - [x] init and join with automatic copy certs | ||
| - [x] Provide pre built “developer” workflow for kubeadm upgrades | ||
| - [x] reset |
There was a problem hiding this comment.
huge +1 for doing this in kinder 🙃
There was a problem hiding this comment.
we should think about making kinder plugable in prow / kubetest(2) / test-infra.
reset is definitely something we want to e2e eventually. the other day we fixed a panic that was uncaught, because we don't have signal. :\
kinder is an example of kind used as a library, designed for simplifying kubeadm development/local testing
This PR introduces the kinder roadmap/readme file, for collecting the first round of feedback about goals/high-level features before adding the actual kinder code
/kind documentation
/priority important-longterm
/assign @timothysc
/assign @BenTheElder
/assign @neolit123
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews