[1.32] Upgrade select dependencies #17334
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/override tests-e2e-scenarios-bare-metal |
|
@hakman: Overrode contexts on behalf of hakman: tests-e2e-scenarios-bare-metal In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
2 similar comments
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
k8s-ci-robot
removed
the
lgtm
|
@hakman lets try it now |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override tests-e2e-scenarios-bare-metal |
|
@hakman: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
We might need make to make the e2e bare metal job manually-triggered only instead of ran every time. |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The odd thing is that it used to work fine to override it... |
|
I am ok with manual for now + on merge |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/override e2e/tests-e2e-scenarios-bare-metal |
|
@rifelpet: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
For background, this provides a good comparison of the Github Status vs Checks APIs @hakman @ameukam based on this prow code my only theory is that prow used to use app authentication but now uses a personal access token. The Checks API doesn't support PATs. I'm guessing we need to use the checks API to fix the status on the PR. In my testing I was able to update the PR's head commit's "status" but it had no effect on the failing check on the PR itself. . The check-run returns a 403 when used with a fine-grained PAT and they can only work with the repos of a single organization or user, so my own account's token wont work on kubernetes/kops. Status API
{
"url": "https://api.github.com/repos/kubernetes/kops/statuses/050a8dede17b1688c0b5140d4a95c21cb015590f",
"avatar_url": "https://avatars.githubusercontent.com/u/1455650?v=4",
"id": 35332425941,
"node_id": "SC_kwDOA7NwS88AAAAIOfoI1Q",
"state": "success",
"description": "test from peter",
"target_url": null,
"context": "tests-e2e-scenarios-bare-metal",
"created_at": "2025-04-02T02:51:35Z",
"updated_at": "2025-04-02T02:51:35Z",
...Checks APIWith a fine-grainted PAT
{
"message": "Resource not accessible by personal access token",
"documentation_url": "https://docs.github.com/rest/checks/runs#update-a-check-run",
"status": "403"
}@ameukam do you know if prow's authentication to github has changed in the past year or two? Perhaps related to any sig-k8s-infra migration? |
|
We didn't change the Oauth config during the migration, IIRC. And I think we still use the classic PAT for prow. It's possible we are dealing some changes with the Check API since the fine-grained tokens are GA. |
|
I discovered that the job is failing because the staging etcd-manager image isn't found: The repo has a lifecycle setting to delete images after 90 days: and the last etcd-manager commit was 4 months ago. I opened this PR just to trigger a new staging build: kubernetes-sigs/etcd-manager#20 |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Patching some CVEs