Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cilium-config-path mount in cilium-agent container #17319

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

admun
Copy link
Contributor

@admun admun commented Mar 21, 2025

This PR removes cilium-config-path mount in the cilium-agent container.

This mount overwrites config generated by config initContainer. This caused CiliumNodeConfigs not working as expected.

This issue reported in #17269

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @admun!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @admun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus March 21, 2025 16:02
@k8s-ci-robot k8s-ci-robot requested a review from zetaab March 21, 2025 16:02
@hakman
Copy link
Member

hakman commented Mar 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2025
@hakman
Copy link
Member

hakman commented Mar 27, 2025

/retest

1 similar comment
@hakman
Copy link
Member

hakman commented Mar 27, 2025

/retest

@admun
Copy link
Contributor Author

admun commented Mar 31, 2025

hi @hakman,

I think there are still a couple tests failed that seems relevance here. Anything I should be looking at to correct that?

Thanks for kick started this.

@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2025

@admun please run ./hack/update-expected.sh and commit the resulting changes

Copy link

linux-foundation-easycla bot commented Apr 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2025
@admun
Copy link
Contributor Author

admun commented Apr 4, 2025

@rifelpet please see the commit.

Note, I made a mistake when pushing that commit to this PR with my work identify and easyCLA not happy about it....

I amended the commit after that and I think the issue should be cleared but the PR seems now become cncf-cla: no, how should I fix it?

nm, fixed the issue w/ some help.

@admun admun force-pushed the cilium-config-path branch from 2e380df to f1d81cb Compare April 4, 2025 19:16
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 4, 2025
@rifelpet
Copy link
Member

rifelpet commented Apr 4, 2025

/retest

Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 4, 2025

@admun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons f1d81cb link false /test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit fa120b3 into kubernetes:master Apr 4, 2025
31 of 32 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Apr 4, 2025
@admun
Copy link
Contributor Author

admun commented Apr 4, 2025

@rifelpet Thank you so much for approving the PR!

One more question; Would this fix picks up by next release (1.31, I supposed) automatically?

Please let me know if there is a procedure I need to follow to ensure it lands in the next release.

@rifelpet
Copy link
Member

rifelpet commented Apr 5, 2025

I've cherrypicked this back to 1.32 and 1.31 so they should be included in the next round of patch releases

k8s-ci-robot added a commit that referenced this pull request Apr 5, 2025
…19-origin-release-1.32

Automated cherry pick of #17319: Remove cilium-config-path mount in cilium-agent container
k8s-ci-robot added a commit that referenced this pull request Apr 5, 2025
…19-origin-release-1.31

Automated cherry pick of #17319: Remove cilium-config-path mount in cilium-agent container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants