-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cilium-config-path mount in cilium-agent container #17319
Conversation
Welcome @admun! |
Hi @admun. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
1 similar comment
/retest |
hi @hakman, I think there are still a couple tests failed that seems relevance here. Anything I should be looking at to correct that? Thanks for kick started this. |
@admun please run |
@rifelpet please see the commit.
nm, fixed the issue w/ some help. |
7abbb6b
to
2e380df
Compare
4f06d4a
to
2e380df
Compare
2e380df
to
f1d81cb
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@admun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@rifelpet Thank you so much for approving the PR! One more question; Would this fix picks up by next release (1.31, I supposed) automatically? Please let me know if there is a procedure I need to follow to ensure it lands in the next release. |
I've cherrypicked this back to 1.32 and 1.31 so they should be included in the next round of patch releases |
…19-origin-release-1.32 Automated cherry pick of #17319: Remove cilium-config-path mount in cilium-agent container
…19-origin-release-1.31 Automated cherry pick of #17319: Remove cilium-config-path mount in cilium-agent container
This PR removes cilium-config-path mount in the cilium-agent container.
This mount overwrites config generated by config initContainer. This caused CiliumNodeConfigs not working as expected.
This issue reported in #17269