Add support for service annotation propagation #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
silvery1622
force-pushed
the
service-annotation-propagation
branch
2 times, most recently
from
c1ededd to
d0743f1
Compare
|
E2E test passed: team-cluster-api#83 |
zhanggbj
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Thank you for your contribution!
/lgtm
/approve
/hold for other reviewers to take a review
CC @lubronzhan I assume this only impact the paravirtual mode, just tag you for awareness and review.
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
@DanielXiao Could you also review this PR when you have a chance? Thanks! |
DanielXiao
reviewed
Apr 3, 2025
DanielXiao
reviewed
Apr 3, 2025
Enable propagation of Service annotations from workload clusters to influence final Service creation. Only propagates annotations when enable-service-annotation-propagation is explicitly set true.
silvery1622
force-pushed
the
service-annotation-propagation
branch
from
d0743f1 to
9586e38
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
zhanggbj
approved these changes
Apr 8, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DanielXiao, silvery1622, zhanggbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable propagation of Service annotations from workload clusters to influence final Service creation.
Only propagates annotations when enable-service-annotation-propagation is explicitly set true.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: