Skip to content

[cinder-csi-plugin] Update csi-test from 3.1.0 to 4.2.0 #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Apr 26, 2021

What this PR does / why we need it:

upgrade csi-test and fixed a set of issues after the test cases upgraded

Which issue this PR fixes(if applicable):
fixes #1509
fixes #1497
fixes #1498

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 26, 2021
@k8s-ci-robot k8s-ci-robot requested review from chrigl and zetaab April 26, 2021 02:27
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

looks like I hit this issue

root@jjtest1:~/go/src/github.com/cloud-provider-openstack# go mod tidy
go: finding module for package github.com/kubernetes-csi/csi-test/v4/pkg/sanity
go: found github.com/kubernetes-csi/csi-test/v4/pkg/sanity in github.com/kubernetes-csi/csi-test/v4 v4.1.0
go: finding module for package google.golang.org/grpc/examples/helloworld/helloworld
go: finding module for package google.golang.org/grpc/naming
go: found google.golang.org/grpc/examples/helloworld/helloworld in google.golang.org/grpc/examples v0.0.0-20210424002626-9572fd6faeae
go: finding module for package google.golang.org/grpc/naming
k8s.io/cloud-provider-openstack/cmd/openstack-cloud-controller-manager imports
        k8s.io/cloud-provider/options imports
        k8s.io/apiserver/pkg/server/options imports
        k8s.io/apiserver/pkg/storage/storagebackend/factory tested by
        k8s.io/apiserver/pkg/storage/storagebackend/factory.test imports
        go.etcd.io/etcd/integration imports
        go.etcd.io/etcd/proxy/grpcproxy imports
        google.golang.org/grpc/naming: module google.golang.org/grpc@latest found (v1.37.0), but does not contain package google.golang.org/grpc/naming

GoogleCloudPlatform/cloud-foundation-toolkit#902

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 26, 2021

Build succeeded.

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 8, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 8, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 8, 2021

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 8, 2021

/test cloud-provider-openstack-acceptance-test-csi-manila

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-manila

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 8, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 8, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@lingxiankong: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 9, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 9, 2021

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 9, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 9, 2021

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 9, 2021

Build failed.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 9, 2021

/test cloud-provider-openstack-multinode-csi-migration-test

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

In response to this:

/test cloud-provider-openstack-multinode-csi-migration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jun 9, 2021

Build succeeded.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jun 9, 2021

@ramineni @lingxiankong can you help review this ? finally all test green now..

@lingxiankong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@ramineni
Copy link
Contributor

Thanks.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ramineni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4d6ecb6 into kubernetes:master Jun 11, 2021
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants