Treat unspecified keys as their default value if provided

[jennybuckley]

Replacement for #79
Relies on default key values being part of the schema so we can treat null as that value when constructing field paths, instead of actually doing defaulting.

Probably won't allow this except for some existing cases like containerPorts

cc @apelisse

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennybuckley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jennybuckley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[apelisse]

How do you plan on generating the default field value?

[jennybuckley]

Talked offline, but I'll write it here too.

The plan is to get this from the openapi, and that will come from the default markers in types.go that are going to eventually be defined. Like:

// types.go
type Foo struct {
  // +default={"bar": "abc"}
  Foo *Bar
}

# openapi
{"properties": {"name": "foo", ... "default": {"bar": "abc"}}}

# schema.List
defaultedKeys:
- fieldName: foo
  defaultValue: "{\"bar\": \"abc\"}"

[apelisse]

Right, I like that idea.

Are we going to generate defaultedKeys only for keys or for all values?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[jennybuckley]

rebased

[jennybuckley]

#83 (comment)

I think only for defaulted keys, but that can be decided once we are integrating this into kube-openapi

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.