Allow post-delete job to be disabled #2104
Conversation
There are situations where the modifications performed by the NFD need to be preserved even after its removal. One such use case arises when NFD is installed as part of another project. By design, uninstalling the parent project does not remove all its components. However, the remaining components still rely on the labels created by NFD. If NFD is removed, these labels will be deleted, causing dependent components to fail. To maintain system integrity and ensure continued functionality, adding the 'postDeleteCleanup' option that allows any modifications made by NFD to be preserved upon its removal. Signed-off-by: Aleksey Senin <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
Hi @alekseysen. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alekseysen, ozhuraki The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There are situations where the modifications performed by the NFD need to be preserved even after its removal.
One such use case arises when NFD is installed as part of another project. By design, uninstalling the parent project does not remove all its components. However, the remaining components still rely on the labels created by NFD. If NFD is removed, these labels will be deleted, causing dependent components to fail.
To maintain system integrity and ensure continued functionality, adding the 'postDeleteCleanup' option that allows any modifications made by NFD to be preserved upon its removal.