bump golang 1.22.0 and update deps #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
astoycos
added
the
do-not-merge/hold
astoycos
changed the title
astoycos
commented
Jul 8, 2024
astoycos
commented
Jul 8, 2024
tssurya
suggested changes
Jul 9, 2024
k8s-ci-robot
added
the
needs-rebase
bump controller-runtime and controller-tools to the latest versions. Fixup some of the generation code to support the change. Signed-off-by: astoycos <[email protected]>
astoycos
force-pushed
the
fix-ci
branch
2 times, most recently
from
15eb445 to
4f30d14
Compare
k8s-ci-robot
removed
the
needs-rebase
Dyanngg
approved these changes
Jul 9, 2024
| mkdir -p "$GOPATH/src/sigs.k8s.io" | ||
| ln -sf "${SCRIPT_ROOT}" "$GOPATH/src/sigs.k8s.io/network-policy-api" | ||
|
|
||
| readonly API_VERSION=v1alpha1 |
There was a problem hiding this comment.
I like that we now have a single place in the script for version. Let's maybe also add a reminder that everytime there's a spec bump this need to be updated
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astoycos, Dyanngg, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our prow based CI has been failing/flaking all over the place this seems to fix things. Update the controller-runtime and controller-tools dependencies, this requires some changes to the controller tools commands.