-
Notifications
You must be signed in to change notification settings - Fork 70
Creating LWS site #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating LWS site #426
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Edwinhr716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently work in progress, still missing:
In order to view current iteration of website:
Following kubernetes-sigs/jobset#402 |
Thanks @Edwinhr716 |
Added core content to the LWS site, PTAL to review the content. We should have the user guides here as well, but I think that can be a follow up item (though it can be somewhat awkward since a lot of the user guides require setup) Ran into some issues trying to run |
leaderworkerset-multi-template-2-3 1/1 Running 0 106s | ||
``` | ||
|
||
## Multi-Template for Pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @Edwinhr716
The previous example is "Multi-Template", which appears to have some repetition.
So, is the previous example supposed to be the "Minimal Sample" based on the configuration found at https://github.com/kubernetes-sigs/lws/blob/main/docs/examples/sample/lws.yaml, and this example a Multi-Template configuration?
Or if the "Minimal Sample" is not needed, then perhaps this section is unnecessary as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah was debating what yaml file to include as an example, since multi-template one should be the default. I'll change it to the minimal sample one instead
@kerthcet I added the images, but for some reason it creates a very wide white rectangle ![]() do you have any idea how to fix it? Messed around with the svg and css a bit, but couldn't fix it |
HI @Edwinhr716 If we update the `logo.svg' with https://github.com/cncf/artwork/blob/78c2f5e5ab038b8a0ae0fab00f773c6445a55030/projects/lws/icon/color/lws-icon-color.svg , it can work correctly like Edwinhr716#1 . |
update logo svg
/lgtm |
Thanks @Edwinhr716 for all your efforts! |
What type of PR is this?
/kind documentation
What this PR does / why we need it
Adds the files needed for the LWS site lws.sigs.k8s.io
Which issue(s) this PR fixes
Fixes #372
Special notes for your reviewer
Does this PR introduce a user-facing change?