Skip to content

Creating LWS site #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2025
Merged

Conversation

Edwinhr716
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it

Adds the files needed for the LWS site lws.sigs.k8s.io

Which issue(s) this PR fixes

Fixes #372

Special notes for your reviewer

Does this PR introduce a user-facing change?


@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Edwinhr716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kerthcet March 12, 2025 01:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 12, 2025
@Edwinhr716
Copy link
Contributor Author

Edwinhr716 commented Mar 12, 2025

Currently work in progress, still missing:

  • update npm dependencies
  • Add actual content
  • update k8s logo to LWS logo. @kerthcet ideally we want to have equivalents of the LWS logo of all of the k8s logos in this PR

In order to view current iteration of website:

  • install npm and hugo
  • cd site/ && npm install
  • hugo server

Following kubernetes-sigs/jobset#402

@kerthcet
Copy link
Contributor

Thanks @Edwinhr716

@Edwinhr716 Edwinhr716 changed the title [WIP] Creating LWS site Creating LWS site Mar 12, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2025
@Edwinhr716
Copy link
Contributor Author

Edwinhr716 commented Mar 12, 2025

Added core content to the LWS site, PTAL to review the content.

We should have the user guides here as well, but I think that can be a follow up item (though it can be somewhat awkward since a lot of the user guides require setup)

Ran into some issues trying to run make api-genref for the API fields, will look to add that later as well

leaderworkerset-multi-template-2-3 1/1 Running 0 106s
```

## Multi-Template for Pods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Edwinhr716

The previous example is "Multi-Template", which appears to have some repetition.

So, is the previous example supposed to be the "Minimal Sample" based on the configuration found at https://github.com/kubernetes-sigs/lws/blob/main/docs/examples/sample/lws.yaml, and this example a Multi-Template configuration?
Or if the "Minimal Sample" is not needed, then perhaps this section is unnecessary as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah was debating what yaml file to include as an example, since multi-template one should be the default. I'll change it to the minimal sample one instead

@Edwinhr716
Copy link
Contributor Author

@kerthcet I added the images, but for some reason it creates a very wide white rectangle

Screenshot 2025-03-13 at 11 19 48 AM

do you have any idea how to fix it? Messed around with the svg and css a bit, but couldn't fix it

@gracie-guo
Copy link

kubernetes-sigs/jobset#402

We checked the svg file and used SVG Autocrop to clear the attribute.
The new version we uploaded would have no problem with attribute conflict.

But the white background with a blue border was caused by added css, these were not included in the original svg file.

Screenshot 2025-03-14 at 10 49 31

@yankay
Copy link
Member

yankay commented Mar 14, 2025

@kerthcet I added the images, but for some reason it creates a very wide white rectangle

Screenshot 2025-03-13 at 11 19 48 AM do you have any idea how to fix it? Messed around with the svg and css a bit, but couldn't fix it

HI @Edwinhr716
Thanks to @gracie-guo 's help.

If we update the `logo.svg' with https://github.com/cncf/artwork/blob/78c2f5e5ab038b8a0ae0fab00f773c6445a55030/projects/lws/icon/color/lws-icon-color.svg , it can work correctly like Edwinhr716#1 .

The sceenshot is:
image

@ahg-g
Copy link
Contributor

ahg-g commented Mar 14, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 884af7f into kubernetes-sigs:main Mar 14, 2025
5 of 8 checks passed
@kerthcet
Copy link
Contributor

Thanks @Edwinhr716 for all your efforts!

@kerthcet kerthcet mentioned this pull request Mar 26, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a website with logo design
6 participants