Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new component config flag #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new component config flag #325
Changes from all commits
6044f7e
6239bc4
6f0c7fa
2b9d797
9890e38
6174e09
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we actually need to make those two (host and certDir) configurable? I don't see why would someone wants to change them. I think it is important to have a tighter API and only expose what we think users will actually want to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I agree with tighter API makes sense, there are various cluster types and webhook configurations are one of the most dynamic. User may want to modify
Host
or temp directory for CertDir might be different than/tmp
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since LeaderElection is a type that we import, we can default it using the upstream
RecommendedDefaultLeaderElectionConfiguration
from component-base.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are importing currently. See L:77 https://github.com/kubernetes-sigs/lws/pull/325/files#diff-2f4f8def1b75dcb7b504613245740aa55320208fe63c4d75c30179f13fc7f51eR77