Make lws image multi-platform #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
cncf-cla: yes
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
support-multi-platform
branch
from
01b2aea to
58db41d
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/retest |
|
HI @ahg-g |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Edwinhr716
reviewed
Jan 16, 2025
| @@ -149,6 +156,7 @@ run: manifests fmt vet ## Run a controller from your host. | |||
| .PHONY: image-build | |||
| image-build: | |||
| $(IMAGE_BUILD_CMD) -t $(IMG) \ | |||
| --platform=$(PLATFORMS) \ | |||
There was a problem hiding this comment.
This line causes the make image-build command to break
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it
I modified Makefile and Dockerfile so that we can provide the multi-platform supported container image.
Which issue(s) this PR fixes
Fixes #275
Special notes for your reviewer
Does this PR introduce a user-facing change?