Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortname lws for API & sort out build image command #30

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Add shortname lws for API & sort out build image command #30

merged 3 commits into from
Mar 3, 2024

Conversation

kerthcet
Copy link
Contributor

@kerthcet kerthcet commented Mar 3, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it

Commits:

  1. We can now build customized image by specifying IMAGE_REGISTRY
  2. Reduce controller resource requests from 2C2Gi to 1C1Gi for local experiment
  3. Add shortName lws for leaderWorkerSet, and remove folder /artifacts, which is ignored by .gitignore now.

Which issue(s) this PR fixes

Part of #29

Special notes for your reviewer

Does this PR introduce a user-facing change?

Add shortName `lws` for leaderWorkerSet API object.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 3, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 3, 2024 11:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 3, 2024
kerthcet
kerthcet commented Mar 3, 2024
View reviewed changes
Makefile
@@ -16,6 +14,13 @@ endif
# tools. (i.e. podman)
CONTAINER_TOOL ?= docker

GIT_TAG ?= $(shell git describe --tags --dirty --always)
# Image URL to use all building/pushing image targets
IMAGE_REGISTRY ?= gcr.io/k8s-staging-lws
Copy link
Contributor Author

@kerthcet kerthcet Mar 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need an official image address, gcr.io/k8s-staging-lws I think so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good, I guess we need a PR similar to kubernetes/k8s.io#5144

@ahg-g
Copy link
Contributor

ahg-g commented Mar 3, 2024

/label tide/merge-method-squash
/lgtm
/approve

Can we please update the description to indicate that this PR is part of #29

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 3, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit a73ae42 into kubernetes-sigs:main Mar 3, 2024
4 checks passed
@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 4, 2024

/label tide/merge-method-squash /lgtm /approve

Can we please update the description to indicate that this PR is part of #29

Done

@kerthcet kerthcet mentioned this pull request Mar 4, 2024
Closed
Edwinhr716 pushed a commit to Edwinhr716/lws that referenced this pull request Mar 4, 2024
@kerthcet @Edwinhr716
Add shortname lws for API & sort out build image command (kubernetes-…
04bf45c 
…sigs#30)

* Build image based on git hash

Signed-off-by: kerthcet <[email protected]>

* Reduce the resource requests for local testing

Signed-off-by: kerthcet <[email protected]>

* Add short name lws for leaderWorkerSet

Signed-off-by: kerthcet <[email protected]>

---------

Signed-off-by: kerthcet <[email protected]>
ardaguclu pushed a commit to ardaguclu/lws that referenced this pull request Feb 10, 2025
@openshift-merge-bot
Merge pull request kubernetes-sigs#30 from ardaguclu/add-prow-dockerfile
4dc2ae6 
<CARRY>: CNTRLPLANE-211: Add Prow Dockerfile and Update Konflux Dockerfile accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kerthcet @ahg-g @k8s-ci-robot