Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

Correct docs for a Cluster Selector case #1239

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

robinbraemer
Copy link
Contributor

While browsing I found that an example in the Cluster Selector part of the userguide has a volatile mistake.

I think this part of the documentation has a volatile mistake.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @robinbraemer!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from font and gyliu513 June 27, 2020 10:53
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2020
@robinbraemer
Copy link
Contributor Author

/assign @font

@RainbowMango
Copy link
Contributor

Thanks, @robinbraemer !

/lgtm
And left approval to @font or @hectorj2f
/assign @hectorj2f

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2020
@hectorj2f
Copy link
Contributor

/lgtm

Co-authored-by: Jimmi Dyson <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@jimmidyson
Copy link
Contributor

/approve

@robinbraemer Could you squash the commits please?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, robinbraemer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020
@hectorj2f
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5f2292c into kubernetes-retired:master Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants