-
Notifications
You must be signed in to change notification settings - Fork 531
increase resource limits for kubefed controller #1236
increase resource limits for kubefed controller #1236
Conversation
Welcome @zryfish! |
/lgtm |
charts/kubefed/values.yaml
Outdated
@@ -13,8 +13,8 @@ controllermanager: | |||
imagePullPolicy: IfNotPresent | |||
resources: | |||
limits: | |||
cpu: 100m | |||
memory: 128Mi | |||
cpu: 400m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, raise it to 500m, we have this limit for the CPU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, set the cpu limit to 500m, we saw that value to work well on big clusters. I'll allocate 1Gi as memory limit.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, zryfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Default resource limits in the chart is too low now, it's easy to cause OOM issues, like #1235. Enlarge kubefed controller resource limits would cover more cases.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1235
Special notes for your reviewer: