This repository was archived by the owner on Apr 25, 2023. It is now read-only.
kubefedctl: Set host cluster context to current context if empty #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/M
|
cc: @qiujian16 |
xunpan
reviewed
Aug 2, 2019
|
Rebased |
For any invocation of `kubefedctl` that does not specify a value for `--host-cluster-context`, the current config context will be used. However, other usage of the `HostClusterContext` variable requires explicitly looking up the name of the current context to avoid using an empty string. Previously the `join` command was fixed to lookup the current context. This change ensures the same lookup is performed for all `kubefedctl` commands.
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any invocation of
kubefedctlthat does not specify a value for--host-cluster-context, the current config context will beused. However, other usage of the
HostClusterContextvariable requires explicitly looking up the name of the current context to avoid using an empty string.#1065 fixed the
joincommand to lookup the current context. This change ensures the same lookup is performed for allkubefedctlcommands.