Skip to content

Bump Go to 1.17 #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

Bump Go to 1.17 #744

merged 1 commit into from
Dec 6, 2021

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 27, 2021

Signed-off-by: Gábor Lipták [email protected]

Fixes #...
Related issue: #...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @gliptak!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 27, 2021
@corneliusweig
Copy link
Contributor

This change will only run our test suite with the 1.17 Go release. Do you also want to switch the project to go 1.17 (by modifying go.mod)?

@gliptak
Copy link
Contributor Author

gliptak commented Nov 28, 2021

@corneliusweig updated

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2021
@chriskim06
Copy link
Member

I think maybe you want to change

goVer: [1.16, 1.17]

to just

goVer: [1.17]

or maybe update how the test that's failing works. i haven't really looked into that yet

@gliptak
Bump Go to 1.17
8541b63 
Signed-off-by: Gábor Lipták <[email protected]>
@gliptak
Copy link
Contributor Author

gliptak commented Dec 4, 2021

@chriskim06 updated

@chriskim06
Copy link
Member

/retest

@chriskim06
Copy link
Member

guessing that command doesn't work here, I'm going to manually rerun these checks

@ahmetb
Copy link
Member

ahmetb commented Dec 6, 2021

I have re-triggered Netlify builds manually but if it continues to fail, feel free to merge manually. Idk what causes it to fail like this.

@ahmetb
Copy link
Member

ahmetb commented Dec 6, 2021

Let's merge and see how Netlify takes it.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, gliptak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit b015efb into kubernetes-sigs:master Dec 6, 2021
@ferhatelmas ferhatelmas mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gliptak @k8s-ci-robot @corneliusweig @chriskim06 @ahmetb