Skip to content

Remove ARCH specific apt repo info to enable arm support #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hh
Copy link

@hh hh commented Feb 20, 2019

No description provided.

Devan Carpenter and others added 2 commits February 18, 2019 21:23
This removes the requirement for x86_64, and will now detect the
CPU architecture.
Base image: Support multiple architectures
@k8s-ci-robot
Copy link
Contributor

Welcome @hh! It looks like this is your first PR to kubernetes-sigs/kind 🎉

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bentheelder

If they are not already assigned, you can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 20, 2019

@hh: The following test failed for commit 77d5157, say /retest to rerun them:

Test name Details Rerun command
pull-kind-verify link /test pull-kind-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ARG CNI_BASE_URL="https://storage.googleapis.com/kubernetes-release/network-plugins/"
ARG CNI_URL="${CNI_BASE_URL}${CNI_TARBALL}"
RUN curl -sSL --retry 5 --output /tmp/cni.tgz "${CNI_URL}" \
RUN export ARCH=$(dpkg --print-architecture) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@BenTheElder
Copy link
Member

changes LGTM, can you squash this to remove the merge commit and run hack/update-generated.sh?

@BenTheElder
Copy link
Member

looks like the linuxfoundation CLA is also unhappy :(

@neolit123
Copy link
Member

/check-cla

@alejandrox1
Copy link
Contributor

/retest

@alejandrox1
Copy link
Contributor

cla wise there are two authors to this PR. @devaii have you signed the CLA as well?

Pull-kind-verify failing with:

verifying generated ...
unexpectedly dirty working directory after hack/update-generated.sh
...

One or more verify checks failed! See output above...

So as Ben commented, need to run hack/update-generated.sh.

Pull-kind-performance on the other hand should be fixed by #335 (?)

W0223 14:17:25.415] Error: error building node image: failed to copy build artifact: lstat /go/src/k8s.io/kubernetes/bazel-bin/build/debs/kubectl.deb: no such file or directory
W0223 14:17:25.418] + cleanup
W0223 14:17:25.418] + kind export logs /workspace/_artifacts/logs
W0223 14:17:25.547] Error: unknown cluster "kind"
W0223 14:17:25.550] + true
W0223 14:17:25.550] + [[ '' = true ]]
W0223 14:17:25.551] + rm -f _output/bin/e2e.test
W0223 14:17:25.552] + [[ -n /tmp/tmp.VVaqHZHqxJ ]]
W0223 14:17:25.552] + rm -rf /tmp/tmp.VVaqHZHqxJ
W0223 14:17:25.567] Traceback (most recent call last):
W0223 14:17:25.568]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 50, in <module>
W0223 14:17:25.568]     main(ARGS.env, ARGS.cmd + ARGS.args)
W0223 14:17:25.568]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 41, in main
W0223 14:17:25.568]     check(*cmd)
W0223 14:17:25.568]   File "/workspace/./test-infra/jenkins/../scenarios/execute.py", line 30, in check
W0223 14:17:25.568]     subprocess.check_call(cmd)
W0223 14:17:25.568]   File "/usr/lib/python2.7/subprocess.py", line 186, in check_call
W0223 14:17:25.568]     raise CalledProcessError(retcode, cmd)
W0223 14:17:25.569] subprocess.CalledProcessError: Command '('bash', '-c', 'cd ./../../k8s.io/kubernetes && ./../../sigs.k8s.io/kind/hack/ci/e2e.sh')' returned non-zero exit status 1
E0223 14:17:25.573] Command failed
I0223 14:17:25.573] process 703 exited with code 1 after 2.5m
E0223 14:17:25.573] FAIL: pull-kind-conformance-parallel

@alejandrox1
Copy link
Contributor

alejandrox1 commented Feb 23, 2019

Checking to see if pull-kind-conformance-parallel clears up
/retest

@devaips
Copy link

devaips commented Feb 24, 2019

I have now signed the CNCF CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 24, 2019
@dims
Copy link
Member

dims commented Mar 4, 2019

@devaii i kicked the tires, looks good. can you please fix the verify error?

@dims
Copy link
Member

dims commented Mar 4, 2019

cc @vielmetti

@dims dims mentioned this pull request Mar 4, 2019
@dims
Copy link
Member

dims commented Mar 5, 2019

@hh @devaii looks like #358 got merged. So let's close this out.

/close

@k8s-ci-robot
Copy link
Contributor

@dims: Closed this PR.

In response to this:

@hh @devaii looks like #358 got merged. So let's close this out.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

Thanks again all!

stg-0 pushed a commit to stg-0/kind that referenced this pull request Feb 6, 2024
* Initial gke support

* Fix gcr authentication

* Minor fixes

* Fix gcr authentication

* Enable machine pools for gke

* Enable gke in capg

* Add google artifact registry support

* Add gke version validation

* Improve error message

* Update cluster-operator version

* Fix gke install logic
stg-0 pushed a commit to stg-0/kind that referenced this pull request Feb 6, 2024
* chore: bump azure provider

* bump azure provider version

* [CLOUD-109] Integrar GKE como nuevo provider (kubernetes-sigs#320)

* Initial gke support

* Fix gcr authentication

* Minor fixes

* Fix gcr authentication

* Enable machine pools for gke

* Enable gke in capg

* Add google artifact registry support

* Add gke version validation

* Improve error message

* Update cluster-operator version

* Fix gke install logic

* Improve execute command retries (kubernetes-sigs#298)

* Improve execute command retries

* Fix kubeconfig condition

* Fix ecr login when ecr is in another region

* Remove comment

* [BUILD] 0.17.0-0.3.0: New pre-release

* Prepare for next version: 0.17.0-0.3.0-SNAPSHOT

* Prepare for next version: 0.17.0-0.3.1-SNAPSHOT

* Improve retry logic

---------

Co-authored-by: stratiocommit <[email protected]>

* Feature/add infra validations (kubernetes-sigs#335)

* version v0.18.0-alpha

* update docs for v0.17.0

* fix kind version in readme

* comments-update-buildcontext

* Added validations for azs, k8sVersion, vpcs and subnets in each provider

* fixing dependency bugs

* Merge with master

* fixed gcp

* Update pkg/cluster/internal/validate/gcp.go

Co-authored-by: esierra-stratio <[email protected]>

* fixed build

* Update CHANGELOG.md

---------

Co-authored-by: Benjamin Elder <[email protected]>
Co-authored-by: Daman <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
Co-authored-by: esierra-stratio <[email protected]>

* version v0.18.0-alpha

* delete unneeded files

* add CHANGELOG

---------

Co-authored-by: Francisco Augusto <[email protected]>
Co-authored-by: stratiocommit <[email protected]>
Co-authored-by: lreciomelero <[email protected]>
Co-authored-by: Benjamin Elder <[email protected]>
Co-authored-by: Daman <[email protected]>
Co-authored-by: Kubernetes Prow Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants