-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove ARCH specific apt repo info to enable arm support #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This removes the requirement for x86_64, and will now detect the CPU architecture.
Base image: Support multiple architectures
Welcome @hh! It looks like this is your first PR to kubernetes-sigs/kind 🎉 |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hh If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hh: The following test failed for commit 77d5157, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ARG CNI_BASE_URL="https://storage.googleapis.com/kubernetes-release/network-plugins/" | ||
ARG CNI_URL="${CNI_BASE_URL}${CNI_TARBALL}" | ||
RUN curl -sSL --retry 5 --output /tmp/cni.tgz "${CNI_URL}" \ | ||
RUN export ARCH=$(dpkg --print-architecture) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat!
changes LGTM, can you squash this to remove the merge commit and run |
looks like the linuxfoundation CLA is also unhappy :( |
/check-cla |
/retest |
cla wise there are two authors to this PR. @devaii have you signed the CLA as well? Pull-kind-verify failing with:
So as Ben commented, need to run Pull-kind-performance on the other hand should be fixed by #335 (?)
|
Checking to see if pull-kind-conformance-parallel clears up |
I have now signed the CNCF CLA |
@devaii i kicked the tires, looks good. can you please fix the verify error? |
cc @vielmetti |
@dims: Closed this PR. |
Thanks again all! |
* Initial gke support * Fix gcr authentication * Minor fixes * Fix gcr authentication * Enable machine pools for gke * Enable gke in capg * Add google artifact registry support * Add gke version validation * Improve error message * Update cluster-operator version * Fix gke install logic
* chore: bump azure provider * bump azure provider version * [CLOUD-109] Integrar GKE como nuevo provider (kubernetes-sigs#320) * Initial gke support * Fix gcr authentication * Minor fixes * Fix gcr authentication * Enable machine pools for gke * Enable gke in capg * Add google artifact registry support * Add gke version validation * Improve error message * Update cluster-operator version * Fix gke install logic * Improve execute command retries (kubernetes-sigs#298) * Improve execute command retries * Fix kubeconfig condition * Fix ecr login when ecr is in another region * Remove comment * [BUILD] 0.17.0-0.3.0: New pre-release * Prepare for next version: 0.17.0-0.3.0-SNAPSHOT * Prepare for next version: 0.17.0-0.3.1-SNAPSHOT * Improve retry logic --------- Co-authored-by: stratiocommit <[email protected]> * Feature/add infra validations (kubernetes-sigs#335) * version v0.18.0-alpha * update docs for v0.17.0 * fix kind version in readme * comments-update-buildcontext * Added validations for azs, k8sVersion, vpcs and subnets in each provider * fixing dependency bugs * Merge with master * fixed gcp * Update pkg/cluster/internal/validate/gcp.go Co-authored-by: esierra-stratio <[email protected]> * fixed build * Update CHANGELOG.md --------- Co-authored-by: Benjamin Elder <[email protected]> Co-authored-by: Daman <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]> Co-authored-by: esierra-stratio <[email protected]> * version v0.18.0-alpha * delete unneeded files * add CHANGELOG --------- Co-authored-by: Francisco Augusto <[email protected]> Co-authored-by: stratiocommit <[email protected]> Co-authored-by: lreciomelero <[email protected]> Co-authored-by: Benjamin Elder <[email protected]> Co-authored-by: Daman <[email protected]> Co-authored-by: Kubernetes Prow Robot <[email protected]>
No description provided.