Skip to content

doc: fix urls #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2019
Merged

doc: fix urls #296

merged 2 commits into from
Feb 13, 2019

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Feb 13, 2019 •
edited
Loading

maybe also close #271

Signed-off-by: Jintao Zhang [email protected]

@tao12345666333
doc: fix urls
043a862 
Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2019
BenTheElder
BenTheElder approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@BenTheElder
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2019
@tao12345666333
Copy link
Member Author

/test pull-kind-verify

@tao12345666333
Copy link
Member Author

I should run hack/update-generated.sh

@tao12345666333
update base images_sources
215d341 
Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@tao12345666333
Copy link
Member Author

https://deploy-preview-296--k8s-kind.netlify.com

@tao12345666333
Copy link
Member Author

maybe i need a lgtm label. @BenTheElder Thanks. ❤️

@lizebang lizebang mentioned this pull request Feb 13, 2019
Closed
BenTheElder
BenTheElder approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 54ff8b1 into kubernetes-sigs:master Feb 13, 2019
@tao12345666333 tao12345666333 deleted the fix-broken-url branch February 14, 2019 02:04
stg-0 added a commit to stg-0/kind that referenced this pull request Oct 27, 2023
@stg-0
Docs: Fix pods cidr (kubernetes-sigs#296)
7742e68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove the reference about k8s.gcr.io/debian-base
3 participants
@tao12345666333 @k8s-ci-robot @BenTheElder