Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't symlink /dev/console to /dev/kmsg #2913

Merged
merged 2 commits into from
Sep 22, 2022
Merged

don't symlink /dev/console to /dev/kmsg #2913

merged 2 commits into from
Sep 22, 2022

Conversation

BenTheElder
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2022
@aojea
Copy link
Contributor

aojea commented Sep 7, 2022

is a kernel issue then?

@BenTheElder
Copy link
Member Author

is a kernel issue then?

See the linked discussion for more but TLDR ...

They're not the same and systemd can reject this bogus symlink. lxc removed the option to do this, and the lxc option was the original justification for this being a reasonable solution.

We could instead fake out a file, but I think this is only in environments like LXC where the user can instead ensure the LXC environment has a placeholder.

@BenTheElder BenTheElder changed the title [WIP] [RFC] don't symlink /dev/console to /dev/kmsg don't symlink /dev/console to /dev/kmsg Sep 21, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2022
@BenTheElder
Copy link
Member Author

we should do this after #2905

@BenTheElder BenTheElder added this to the v0.16.0 milestone Sep 22, 2022
@BenTheElder BenTheElder merged commit d0d9c5d into kubernetes-sigs:main Sep 22, 2022
@BenTheElder BenTheElder deleted the no-symlink-kmsg branch September 22, 2022 03:13
@BenTheElder
Copy link
Member Author

not only is this a simplification, the previous change was incorrect.

if we see substantial issues with this, and those environments cannot be fixed, we can consider instead creating a fake file.

but I think this complexity belongs in these unusual, broken environments.

@BenTheElder
Copy link
Member Author

one more base image change to pickup before #2933 + v0.16.0 ... containerd 1.6.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @aojea