Use config metrics binding address if flag is not set

[ardaguclu]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Metrics in options is directly initialized by using the value in metricAddr regardless of the value in config file (which should not happen). This PR overwrites the metricAddr by the value in config file unless flag is explicitly set.

Does this PR introduce a user-facing change?

The BindAddress value in config file will be used unless flag is explicitly set

[k8s-ci-robot]

Hi @ardaguclu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	0892070
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/6788df66a9f49a0008dd5a9b

[kannon92]

/ok-to-test

[kannon92]

/lgtm
/assign @danielvegamyhre @ahg-g

[ahg-g]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ahg-g]

@kannon92 what about this one? I think we can cherrypick this one too since it is a bug.

[kannon92]

I don't think this one makes sense to cherry-pick. This became a bug when we dropped kube-rbac-proxy.

But I actually don't see us using this in 0.7 release branch. So not sure if this is worth carrying.