Skip to content

Turn off internal cert management via config #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

Turn off internal cert management via config #755

merged 1 commit into from
Jan 16, 2025

Conversation

ardaguclu
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Currently config file contains internal cert management related properties. However it ignores the enable field of this resource. This PR takes account this enable field into here (just like Kueue) and if the field is set to false, this PR skips running internal cert management rotator.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

config.internalCertManagement.enable field can be used to disable internal cert management

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ardaguclu!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ardaguclu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit e34c33d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/67889ec97d4fc3000834985a

ardaguclu
ardaguclu commented Jan 16, 2025
View reviewed changes
main.go
if err = cert.CertsManager(mgr, cfg, certsReady); err != nil {
setupLog.Error(err, "unable to setup cert rotation")
os.Exit(1)
if cfg.InternalCertManagement != nil && *cfg.InternalCertManagement.Enable {
Copy link
Contributor Author

@ardaguclu ardaguclu Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value of this field is true, so this should be backwards compatible?

@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2025
@kannon92
Copy link
Contributor

/remove-feature
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 16, 2025
@kannon92
Copy link
Contributor

/lgtm

/assign @ahg-g @danielvegamyhre

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@danielvegamyhre
Copy link
Contributor

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit a4512dd into kubernetes-sigs:main Jan 16, 2025
13 checks passed
@ardaguclu ardaguclu deleted the use-internalcertmanagement-enablemenent branch January 16, 2025 17:55
@tenzen-y
Copy link
Member

@kannon92 @danielvegamyhre @ahg-g Should we backport this to release-0.7 branch?

@ahg-g
Copy link
Contributor

ahg-g commented Jan 17, 2025

I am ok with that.

@tenzen-y
Copy link
Member

I am ok with that.

Cool.
/cherry-pick release-0.7

@kannon92
Copy link
Contributor

/cherry-pick release-7.1

@ahg-g
Copy link
Contributor

ahg-g commented Jan 17, 2025

I would like to start the release today, would you like to send a cherry pick for this one?

@kannon92
Copy link
Contributor

Yea, I guess the bot failed. I'll do that right now.

kannon92 pushed a commit to kannon92/jobset that referenced this pull request Jan 17, 2025
@ardaguclu @kannon92
Turn off internal cert management via config (kubernetes-sigs#755)
1719023
kannon92 pushed a commit to kannon92/jobset that referenced this pull request Jan 17, 2025
@ardaguclu @kannon92
Turn off internal cert management via config (kubernetes-sigs#755)
44f9bdb
@kannon92 kannon92 mentioned this pull request Jan 17, 2025
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 17, 2025
@kannon92 @ardaguclu
Turn off internal cert management via config (#755) (#757)
152f624 
Co-authored-by: Arda Güçlü <[email protected]>
@kannon92 kannon92 mentioned this pull request Feb 26, 2025
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@kannon92 kannon92

@ahg-g ahg-g

@danielvegamyhre danielvegamyhre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ardaguclu @k8s-ci-robot @kannon92 @danielvegamyhre @tenzen-y @ahg-g