Skip to content

Setup validation and defaulting webhook #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #43
ahg-g opened this issue Apr 6, 2023 · 11 comments · Fixed by #51
Closed
Tracked by #43

Setup validation and defaulting webhook #6

ahg-g opened this issue Apr 6, 2023 · 11 comments · Fixed by #51
Assignees

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Apr 6, 2023

No description provided.

@danielvegamyhre
Copy link
Contributor

/assign

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 10, 2023

/unassign @danielvegamyhre

@kannon92
Copy link
Contributor

I remember that Kueue had some questions around CEL and webhooks. Do we want to go forward with the assumption that we could use CEL?

kubernetes-sigs/kueue#463

Not sure what backwards capability we want to target so curious if we could include some of these?

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 10, 2023

Using CEL would certainly be better, lets start with that and see how far we can go. Does it cover defaulting too?

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 11, 2023

Things to validate:

  • EnableDNSHostnames is allowed only with completion mode Indexed.

@kannon92
Copy link
Contributor

Should we close this issue?

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 14, 2023

Yes

@ahg-g ahg-g closed this as completed Apr 14, 2023
@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 14, 2023

/reopen

we need to enforce immutability of most fields in the JobSetSpec, I think the only field we should allow for now is suspend

@k8s-ci-robot k8s-ci-robot reopened this Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

@ahg-g: Reopened this issue.

In response to this:

/reopen

we need to enforce immutability of most fields in the JobSetSpec, I think the only field we should allow for now is suspend

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 17, 2023

We may need to setup a defaulting webhook if we are to default things within the job template, like Indexed mode.

@danielvegamyhre
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants