-
Notifications
You must be signed in to change notification settings - Fork 78
Setup validation and defaulting webhook #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/assign |
/unassign @danielvegamyhre |
I remember that Kueue had some questions around CEL and webhooks. Do we want to go forward with the assumption that we could use CEL? Not sure what backwards capability we want to target so curious if we could include some of these? |
Using CEL would certainly be better, lets start with that and see how far we can go. Does it cover defaulting too? |
Things to validate:
|
Should we close this issue? |
Yes |
/reopen we need to enforce immutability of most fields in the JobSetSpec, I think the only field we should allow for now is suspend |
@ahg-g: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We may need to setup a defaulting webhook if we are to default things within the job template, like Indexed mode. |
/assign |
No description provided.
The text was updated successfully, but these errors were encountered: