Skip to content

frontend: Enable details drawer by default #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

frontend: Enable details drawer by default #3381

merged 1 commit into from
May 29, 2025

Conversation

joaquimrocha
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ashu8912 May 28, 2025 10:50
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sniok May 28, 2025 10:50
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, sniok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

skoeva
skoeva reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a fixup commit for the failing frontend test; there's still the build container test failure

@joaquimrocha joaquimrocha force-pushed the details-drawer-default branch 2 times, most recently from 541d857 to 0fd10a6 Compare May 28, 2025 16:26
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2025
@joaquimrocha joaquimrocha force-pushed the details-drawer-default branch 2 times, most recently from 9b95c7f to ef0bbdc Compare May 29, 2025 09:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2025
@joaquimrocha joaquimrocha force-pushed the details-drawer-default branch from ef0bbdc to ce2d1c8 Compare May 29, 2025 09:38
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2025
@joaquimrocha joaquimrocha force-pushed the details-drawer-default branch from ce2d1c8 to a01371c Compare May 29, 2025 15:12
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2025
@joaquimrocha joaquimrocha merged commit d320b07 into kubernetes-sigs:main May 29, 2025
11 of 12 checks passed
@joaquimrocha joaquimrocha deleted the details-drawer-default branch May 29, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoeva skoeva skoeva left review comments

@sniok sniok sniok approved these changes

@ashu8912 ashu8912 Awaiting requested review from ashu8912

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joaquimrocha @k8s-ci-robot @sniok @skoeva