Skip to content

Add storybook vitest integration-new storybook vitest integration #2396 #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

7908837174
Copy link

This PR adds Storybook-Vitest integration to enable running Storybook tests inside Vitest.

Changes:

  • Updated vitest.config.ts to enable Storybook integration
  • Configured the integration to work with the existing project structure

This addresses the issue regarding the new experimental Vitest integration for Storybook tests.

7908837174 and others added 30 commits May 16, 2025 11:14
- Added 40px margin to bottom of sidebar toggle button
- Prevents button from being hidden by auto-hiding taskbar
- Added comprehensive test suite for button accessibility
- Includes responsive design tests
- Maintains cross-platform compatibility

Fixes kubernetes-sigs#1287
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels May 25, 2025
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7014f44 fix: Move sidebar toggle button up to avoid taskbar overlap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 7908837174
Once this PR has been reviewed and has the lgtm label, please assign illume for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 25, 2025
@illume
Copy link
Contributor

illume commented May 25, 2025

Hello.

thank you for this.

However, we can't accept any of your pull requests if there are lots of unrelated commits in them, and the CLA isn't signed. As per my comment here:
#3336 (comment)

@7908837174
Copy link
Author

7908837174 commented May 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants