-
Notifications
You must be signed in to change notification settings - Fork 357
frontend: ClusterTable: Add delete cluster functionality #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: userAdityaa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Very cool. Thanks. By the way... I think we have a confusion. To me deleting a cluster means deleting it. If delete just removes it from the kubeconfig... I was wondering if we should call it "remove"? With a tooltip "Remove cluster context from kube/.config" or so? I think we need to somehow make it more clear what it does. Just reading delete or remove doesn't really make clear what's going to happen. btw. We also have delete in the minikube plugin for clusters. And that ones deletes them. Stop on the other hand stops them, and removes the entry from the kube/.config. |
815e2da
to
3ca52d8
Compare
Yes, that makes sense. I've gone ahead and updated it to Removal. For now, I've only implemented the Removal of the cluster, but I do have plans to integrate Permanent Deletion as well. I'll create a PR for that as soon as I get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Would you mind putting the locale changes into each commit where the change happens? This way each commit will pass tests and therefore be atomic commits.
31b47ac
to
a27f766
Compare
I’ve now included the translations along with the changes in the same commit :) |
Thanks for that! I'll come back to test it tomorrow or so. |
PR Description
Overview
This PR introduces new features to enhance cluster management in the Kubernetes dashboard. It modifies
ClusterContextMenu.tsx
to allow single cluster deletion for all cluster types (previously limited to plugin-based clusters) and adds bulk delete functionality inClusterTable.tsx
. Additionally, it improves the toolbar button layout for a more polished UI.Why This Change?
Previously, cluster deletion was restricted to plugin-based (
dynamic_cluster
) clusters, which limited the ability to manage other cluster types, such as those sourced fromkubeconfig
orin_cluster
. Expanding single delete to all cluster types provides greater flexibility for users to manage their clusters. Additionally, introducing bulk delete functionality enables users to remove multiple clusters at once, streamlining workflows and improving efficiency in cluster management.Screenshots of the changes
Fixes #3053