Skip to content

backend: Refactor portforward/handler_test.go TestStartPortForward to be shorter #3280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task
illume opened this issue May 18, 2025 · 1 comment · May be fixed by #3286 or #3285
Open
1 task

backend: Refactor portforward/handler_test.go TestStartPortForward to be shorter #3280

illume opened this issue May 18, 2025 · 1 comment · May be fixed by #3286 or #3285
Assignees
@AyushSriv06
Labels
backend Issues related to the backend good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. portforward

Comments

@illume
Copy link
Contributor

illume commented May 18, 2025

This function needs to be shorter to reduce the complexity of it, and make it easier to understand.

Currently the code turns off the linter for this issue with "//nolint:funlen".



Related umbrella backend refactoring clean up issue #855 (other pieces of code have the linter disabled and could also be fixed up, feel free to refactor a different function.) If you've already refactored one function, please leave the rest for others.
@illume illume added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. backend Issues related to the backend labels May 18, 2025
@AyushSriv06
Copy link

/assign

@AyushSriv06 AyushSriv06 linked a pull request May 18, 2025 that will close this issue
Open
@meethereum meethereum linked a pull request May 18, 2025 that will close this issue
Open
AyushSriv06 added a commit to AyushSriv06/headlamp that referenced this issue May 19, 2025
@AyushSriv06
Merge branch 'main' into refactor-TestStartPortForward-kubernetes-sig…
e936321 
…s#3280
AyushSriv06 added a commit to AyushSriv06/headlamp that referenced this issue May 20, 2025
@AyushSriv06
Merge branch 'refactor-TestStartPortForward-kubernetes-sigs#3280' of h…
b5da94b 
…ttps://github.com/AyushSriv06/headlamp into refactor-TestStartPortForward-kubernetes-sigs#3280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AyushSriv06 AyushSriv06

Labels
backend Issues related to the backend good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. portforward
Projects
None yet
Milestone
No milestone
2 participants
@illume @AyushSriv06