feat(cloudflare): Support DNS record tags

[7onn]

What does it do ?

This will add a flags to be used on the Cloudflare provider for making comment available for DNS records.

Comment can be set as follows

• As a program flag --cloudflare-record-tags="kubernetes,external-dns"
• Or as Ingress annotations, taking precedence over the program args

annotations:
  external-dns.alpha.kubernetes.io/cloudflare-record-tags: "kubernetes,external-dns,my-app"

Motivation

That's helpful when you already have a lot of records and you'd like to track what external-dns is provisioning there and why.

Fixes #5442

More

I'll do some smoke tests in my staging envs soon! Will post the results here.

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @7onn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

/ok-to-test

[k8s-ci-robot]

@7onn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-external-dns-unit-test	2177040	link	true	/test pull-external-dns-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivankatliarchuk]

any chance to review this comment as well #5411 (comment)?

[7onn]

any chance to review this comment as well #5411 (comment)?

excellent suggestion, thanks; done: f48e5c7

However, I'm still facing the endless loop of UPDATES with this current code. Even more concerningly, the tags aren't updated at all in Cloudflare 🤔 Investigating...

[7onn]

any chance to review this comment as well #5411 (comment)?

@ivankatliarchuk I had to address it on another PR, specially because there was an uncaught bug when splitting the pull request into one specific for comments! https://github.com/kubernetes-sigs/external-dns/pull/5582/files

I forgot to pass the comment on the the updateDNSRecordParam() and getCreateDNSRecordParam()

upate: still no success on troubleshooting why these tags are stuck on an endless loop of updates! tried several things but no success so far; gonna postpone this once again.