-
Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ Bump to gomega v1.17.0, sync/fix some other dependencies #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -3,25 +3,25 @@ module sigs.k8s.io/controller-runtime | |||
go 1.16 | |||
|
|||
require ( | |||
github.com/evanphx/json-patch v5.6.0+incompatible | |||
github.com/evanphx/json-patch v4.12.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now sync with k/k (note: code should be the same as the previous tag as the real v5 is under the /v5 import path)
12801b7
to
41b8fc4
Compare
41b8fc4
to
bfdd61e
Compare
Signed-off-by: Stefan Büringer [email protected]
bfdd61e
to
4161234
Compare
/lgtm |
/hold |
/hold cancel or not (will do another round with alpha4) |
/hold |
/close |
@sbueringer: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
Bumps dependencies. Especially setup-envtest is important as otherwise it isn't compatible with dependencies of the main go.mod (log dependencies).
Alternatively, we can merge #1714 (which is the same + alpha4/Go1.17)