-
Notifications
You must be signed in to change notification settings - Fork 1.4k
📖 update clusterctl provider contract for clusterclass support #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 update clusterctl provider contract for clusterclass support #5582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits, but sounds good in general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits from my side
Q: should we update also documentation in https://cluster-api.sigs.k8s.io/clusterctl/commands/generate-cluster.html
c54f540
to
909a2fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending addressing open comments
909a2fa
to
a8d56db
Compare
/lgtm |
The error in the "Broken Links" pipeline seems to be
This link is in the "Cluster Provider Spec and Status as CRDs" proposal doc and I believe the error is not related to changes in the current PR. |
If I'm not wrong the link is correct, might be a flake... |
/lgtm |
I wonder if this will remove the lgtm label. |
Yup, it will remove them. Just suggested it because getting lgtm again shouldn't be a problem :) I think someone with write or admin access to the repo should be able to restart the workflow. |
a8d56db
to
141601b
Compare
@sbueringer can you please LGTM again 🙏🏼 |
Sure :) /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@ykakarap please give a PSA in the office hours about this documentation being available
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR update the clusterctl provider contract for providers to opt into cluster class support.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #