-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 metrics: use v1beta2 for condition metrics and add metrics for dockercluster devcluster dockermachine devmachine extensionconfig ipaddressclaim and crs #12006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wonder if we should just only emit v1beta2 conditions without a v1beta2 string in the metric name. This gives us future proof metrics from now onwards (we also know that v1beta1 conditions are not exactly perfect) |
7d7a337
to
1fc6261
Compare
In general seems fine. Obviously did not review the diff of the metrics config. I'll do that eventually on 9347. Did you check that our Grafana dashboards still work? (specifically the ones using conditions) |
…ckercluster devcluster dockermachine devmachine extensionconfig ipaddressclaim and crs
943aea4
to
1006ebf
Compare
checked and adjusted dashboards a bit. Hope I catched all cases. |
Thank you very much! /lgtm |
LGTM label has been added. Git tree hash: 16c2f03c9bc03fef869e3fd61c44cd9af631c3de
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@chrischdi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@chrischdi: new pull request created: #12041 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Changes all condition metrics to expose metrics from v1beta2 structs.
Adds new metrics for (only condition metrics for v1beta2):
Generated via #9347
/area devtools
Generated via:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #