🌱 Publish nightly manifests to staging bucket #10489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
cncf-cla: yes
|
/assign @fabriziopandini @chrischdi /hold Will bring it up tomorrow in office hours. We don't have a choice but we should let people know |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9aaaf5044c0bb9abf0001b03fd97e669adf4b2a4
|
|
/lgtm +1 to bring it up at the office hours |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR starts publishing the nightly artifacts to the
k8s-staging-cluster-apibucket, instead of to theartifacts.k8s-staging-cluster-api.appspot.com.The latter is the backing bucket of the google container registry and will go away eventually when we migrate from the container registry to the artifact registry. It was never meant to be used to store files that are not part of container images.
Please note that the new location has a retention of 60 days (as of now). But that should be okay for nightly manifests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #