-
Notifications
You must be signed in to change notification settings - Fork 211
[PROPOSAL] chore: move damdo and salasberryfin to maintainer. #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] chore: move damdo and salasberryfin to maintainer. #1450
Conversation
@richardcase: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/kind chore |
@richardcase: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
huge +1 |
Move damdo and salasberryfin from reviewe to maintainer. Also update the CAPI maintainers/admins. Removed "sig-gcp lead" as they haven't been active on GitHub since 2017. Signed-off-by: Richard Case <[email protected]> stuff Signed-off-by: Richard Case <[email protected]>
9320f01
to
20fb6a3
Compare
/retest |
The time has passed so we can merge. |
/lgtm |
@richardcase: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind other
What this PR does / why we need it:
Move @damdo and @salasberryfin from reviewer to maintainer.
//cc @cpanato
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
This would normally remain open until the next office hours (3rd April). But is Kubecon that week, so unless there are any objections, this will merge on Friday 28th March
TODOs:
Release note: