Skip to content

[PROPOSAL] chore: move damdo and salasberryfin to maintainer. #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

richardcase
Copy link
Member

What type of PR is this?
/kind other

What this PR does / why we need it:

Move @damdo and @salasberryfin from reviewer to maintainer.

//cc @cpanato

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This would normally remain open until the next office hours (3rd April). But is Kubecon that week, so unless there are any objections, this will merge on Friday 28th March

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Move @damdo and @salasberryfin from reviewer to maintainer 🎉 

@k8s-ci-robot
Copy link
Contributor

@richardcase: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind other

What this PR does / why we need it:

Move @damdo and @salasberryfin from reviewer to maintainer.

//cc @cpanato

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

This would normally remain open until the next office hours (3rd April). But is Kubecon that week, so unless there are any objections, this will merge on Friday 28th March

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Move @damdo and @salasberryfin from reviewer to maintainer 🎉 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from damdo and dims March 19, 2025 14:20
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2025
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 20fb6a3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/67dbe9c40dd03f0008c449c9
😎 Deploy Preview https://deploy-preview-1450--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richardcase
Copy link
Member Author

/kind chore

@k8s-ci-robot
Copy link
Contributor

@richardcase: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

/kind chore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cpanato
Copy link
Member

cpanato commented Mar 20, 2025

huge +1

Move damdo and salasberryfin from reviewe to maintainer. Also update the
CAPI maintainers/admins. Removed "sig-gcp lead" as they haven't been
active on GitHub since 2017.

Signed-off-by: Richard Case <[email protected]>

stuff

Signed-off-by: Richard Case <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
@damdo
Copy link
Member

damdo commented Mar 26, 2025

/retest

@richardcase
Copy link
Member Author

The time has passed so we can merge.

@richardcase
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@richardcase: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richardcase richardcase merged commit 9b9c8ba into kubernetes-sigs:main Mar 30, 2025
15 of 16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants