Updated cloudstack go sdk to v2.17.1 #449

sureshanaparti · 2025-06-20T13:10:43Z

Issue #, if available:

Description of changes:

This updates cloudstack go sdk to v2.17.1.

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

netlify · 2025-06-20T13:10:48Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
🔨 Latest commit	`9ce9492`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-cloudstack/deploys/68594b715524250008ca5db0
😎 Deploy Preview	https://deploy-preview-449--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

linux-foundation-easycla · 2025-06-20T13:10:50Z

✅login: sureshanaparti / (c569533)
✅login: sureshanaparti / (c569533, 9ce9492)

The committers listed above are authorized under a signed CLA.

k8s-ci-robot · 2025-06-20T13:10:52Z

Welcome @sureshanaparti!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-cloudstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-cloudstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-06-20T13:10:53Z

Hi @sureshanaparti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

blueorangutan · 2025-06-20T14:00:24Z

Setting up environment failed

blueorangutan · 2025-06-20T15:48:38Z

Setting up environment failed

blueorangutan · 2025-06-20T15:52:30Z

Setting up environment failed

blueorangutan · 2025-06-20T15:53:36Z

Setting up environment failed

vishesh92 · 2025-06-23T09:14:39Z

/ok-to-test

Copilot

Pull Request Overview

This PR updates the CloudStack Go SDK to v2.17.1 and adjusts both production and test code to match the updated API signature. Key changes include:

Updating the parameter order in NewCreateVPCParams to include the VPC CIDR.
Reflecting the API changes in both production code (vpc.go) and tests (vpc_test.go).
Upgrading dependency versions in go.mod, including the cloudstack-go SDK version and several ancillary package updates.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
pkg/cloud/vpc_test.go	Update test expectations to match new CreateVPC parameters.
pkg/cloud/vpc.go	Update production call for NewCreateVPCParams to include vpc.CIDR.
go.mod	Upgrade cloudstack-go and other dependencies to newer versions.

Comments suppressed due to low confidence (2)

pkg/cloud/vpc.go:108

The updated API signature now requires the CIDR as the first parameter. Consider adding a brief in-line comment to clarify this change for future maintainers.

	p := c.cs.VPC.NewCreateVPCParams(vpc.CIDR, vpc.Name, vpc.Name, offeringID, fd.Spec.Zone.ID)

pkg/cloud/vpc_test.go:169

Ensure that the test mock accurately reflects the updated API call by passing the CIDR parameter. A comment noting the API change could be useful for context.

			vs.EXPECT().NewCreateVPCParams(dummyVPC.CIDR, dummyVPC.Name, dummyVPC.Name, offeringID, dummyFD.Spec.Zone.ID).Return(createVPCParams)

codecov-commenter · 2025-06-24T06:58:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.77%. Comparing base (d597e80) to head (9ce9492).
Report is 105 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   25.66%   25.77%   +0.10%     
==========================================
  Files          59       72      +13     
  Lines        5563     6777    +1214     
==========================================
+ Hits         1428     1747     +319     
- Misses       3996     4865     +869     
- Partials      139      165      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

blueorangutan · 2025-06-24T12:49:21Z

Test Results : (tid-877)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.30.11
Kubernetes Version upgrade from: v1.30.11
Kubernetes Version upgrade to: v1.31.7
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr449-sl-877.zip



Summarizing 1 Failure:
 [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/node_helpers.go:56

Ran 33 of 34 Specs in 9618.834 seconds
FAIL! -- 32 Passed | 1 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (9618.84s)
FAIL

vishesh92

/lgtm

k8s-ci-robot · 2025-06-25T05:50:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sureshanaparti, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vishesh92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Updated cloudstack go sdk to v2.17.1

c569533

k8s-ci-robot requested review from davidjumani and rohityadavcloud June 20, 2025 13:10

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2025

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2025

vishesh92 requested review from vishesh92 and Copilot and removed request for davidjumani June 23, 2025 10:59

This comment was marked as outdated.

Sign in to view

Updated create VPC params

9ce9492

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 23, 2025

sureshanaparti requested a review from Copilot June 23, 2025 12:54

Copilot AI reviewed Jun 23, 2025

View reviewed changes

kubernetes-sigs deleted a comment from blueorangutan Jun 24, 2025

vishesh92 approved these changes Jun 25, 2025

View reviewed changes

k8s-ci-robot assigned vishesh92 Jun 25, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2025

k8s-ci-robot merged commit 2bcce63 into kubernetes-sigs:main Jun 25, 2025
10 checks passed

sureshanaparti mentioned this pull request Jun 26, 2025

Support ApiServer to enforce POST requests for state changing APIs and requests with timestamps apache/cloudstack#10899

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated cloudstack go sdk to v2.17.1 #449

Updated cloudstack go sdk to v2.17.1 #449

sureshanaparti commented Jun 20, 2025

Uh oh!

netlify bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

linux-foundation-easycla bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented Jun 20, 2025

Uh oh!

k8s-ci-robot commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

vishesh92 commented Jun 23, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

codecov-commenter commented Jun 24, 2025

Uh oh!

blueorangutan commented Jun 24, 2025

Uh oh!

vishesh92 left a comment

Uh oh!

k8s-ci-robot commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

Updated cloudstack go sdk to v2.17.1 #449

Updated cloudstack go sdk to v2.17.1 #449

Conversation

sureshanaparti commented Jun 20, 2025

Uh oh!

netlify bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Uh oh!

linux-foundation-easycla bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 20, 2025

Uh oh!

k8s-ci-robot commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

blueorangutan commented Jun 20, 2025

Uh oh!

vishesh92 commented Jun 23, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codecov-commenter commented Jun 24, 2025

Codecov Report

Uh oh!

blueorangutan commented Jun 24, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jun 20, 2025 •

edited

Loading

linux-foundation-easycla bot commented Jun 20, 2025 •

edited

Loading