Skip to content

Refactored Tilt with AKS docs #5522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2025

Conversation

alimaazamat
Copy link
Contributor

@alimaazamat alimaazamat commented Mar 27, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Because of new SFI requirements MS tenants cannot make service principals so solution is to use the AKS as management cluster - The Cluster API Provider Azure Book. However these docs needed refactoring and cleaning up from fresh eyes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Cleaned up Tilt with AKS as management Cluster with Internal Load Balancer docs.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 27, 2025
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 27, 2025
Copy link

linux-foundation-easycla bot commented Mar 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alimaazamat / name: Alima Azamat (c44cafe)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @alimaazamat!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @alimaazamat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@willie-yao
Copy link
Contributor

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (8bd1865) to head (c44cafe).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5522      +/-   ##
==========================================
+ Coverage   52.57%   52.60%   +0.03%     
==========================================
  Files         272      272              
  Lines       29470    29485      +15     
==========================================
+ Hits        15493    15511      +18     
+ Misses      13169    13167       -2     
+ Partials      808      807       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 27, 2025
@alimaazamat alimaazamat reopened this Mar 27, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in CAPZ Planning Mar 27, 2025
@willie-yao
Copy link
Contributor

/ok-to-test
/assign

1 similar comment
@alimaazamat
Copy link
Contributor Author

/ok-to-test
/assign

@alimaazamat alimaazamat force-pushed the update-tilt-aks-docs branch from b8574ba to a7a979b Compare March 27, 2025 23:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 27, 2025
@alimaazamat alimaazamat removed their assignment Mar 28, 2025
@alimaazamat alimaazamat force-pushed the update-tilt-aks-docs branch from a7a979b to 5b4271e Compare March 28, 2025 17:51
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on opening up your first PR! Just a few nits and suggestions from my end 🚀

@willie-yao
Copy link
Contributor

/assign @nawazkh

Copy link
Member

@nawazkh nawazkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go Alima! Thank you for combing this README. I've got some minor nits and some suggestions.

@github-project-automation github-project-automation bot moved this from In Progress to Wait-On-Author in CAPZ Planning Mar 28, 2025
@alimaazamat alimaazamat requested a review from nawazkh March 28, 2025 21:51
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Congrats on your first lgtm! :D

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a24756f4f02db03cbeb86150a5d7daa7dcb059b7

@willie-yao willie-yao moved this from Wait-On-Author to Needs Review in CAPZ Planning Mar 28, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 28, 2025

/lgtm
/approve

🎊

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 28, 2025

Could you please squash the commits? hold for squash
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2025
@alimaazamat alimaazamat force-pushed the update-tilt-aks-docs branch from 2aad022 to c44cafe Compare March 28, 2025 23:36
@nawazkh
Copy link
Member

nawazkh commented Mar 29, 2025

/lgtm
/approve

@nawazkh
Copy link
Member

nawazkh commented Mar 29, 2025

/unhold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 85d64b9 into kubernetes-sigs:main Mar 29, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Mar 29, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Done in CAPZ Planning Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants