-
Notifications
You must be signed in to change notification settings - Fork 440
Refactored Tilt with AKS docs #5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored Tilt with AKS docs #5522
Conversation
|
Welcome @alimaazamat! |
Hi @alimaazamat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5522 +/- ##
==========================================
+ Coverage 52.57% 52.60% +0.03%
==========================================
Files 272 272
Lines 29470 29485 +15
==========================================
+ Hits 15493 15511 +18
+ Misses 13169 13167 -2
+ Partials 808 807 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/ok-to-test |
1 similar comment
/ok-to-test |
b8574ba
to
a7a979b
Compare
a7a979b
to
5b4271e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on opening up your first PR! Just a few nits and suggestions from my end 🚀
/assign @nawazkh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way to go Alima! Thank you for combing this README. I've got some minor nits and some suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Congrats on your first lgtm! :D
LGTM label has been added. Git tree hash: a24756f4f02db03cbeb86150a5d7daa7dcb059b7
|
/lgtm 🎊 |
Could you please squash the commits? hold for squash |
2aad022
to
c44cafe
Compare
/lgtm |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nawazkh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Because of new SFI requirements MS tenants cannot make service principals so solution is to use the AKS as management cluster - The Cluster API Provider Azure Book. However these docs needed refactoring and cleaning up from fresh eyes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: