Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase kubeadm verbosity across self-managed templates #5496

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Increase kubeadm verbosity across self-managed templates #5496

merged 1 commit into from
Mar 21, 2025

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Mar 20, 2025 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Increases kubeadm verbosity in the base template
  • Increases kubeadm verbosity in the clusterclass template
  • Increases kubeadm verbosity in the test templates
  • Increases kubeadm verbosity in the dev templates

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Increase Kubeadm Verbosity across self-managed templates for better debugging during kubeadm init/join failures

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 20, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2025
@nawazkh nawazkh changed the title Increase kubeadm verbosity Increase kubeadm verbosity across self-managed templates Mar 20, 2025
@nawazkh
Increase kubeadm verbosity across self-managed clusters
997f1a0 
- increase kubeadm config verbosity in the base template
- increase kubeadm config verbosity in the clusterclass template
- increase kubeadm config verbosity in the test templates
- increase kubeadm config verbosity in the dev templates
- add new line at templates/flavors/clusterclass/kubeadm-controlplane-template.yaml
@nawazkh nawazkh force-pushed the increase_kubeadm_verbosity branch from 3758564 to 997f1a0 Compare March 20, 2025 19:22
@nawazkh nawazkh marked this pull request as ready for review March 20, 2025 19:22
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from marosset March 20, 2025 19:22
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (1abf6ab) to head (997f1a0).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5496   +/-   ##
=======================================
  Coverage   52.57%   52.57%           
=======================================
  Files         272      272           
  Lines       29470    29470           
=======================================
  Hits        15495    15495           
  Misses      13167    13167           
  Partials      808      808

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

willie-yao
willie-yao approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e1ac7dc0c5073eb1ded4e02abebb82628edd71e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@willie-yao
Copy link
Contributor

/test ls

@k8s-ci-robot
Copy link
Contributor

@willie-yao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-azure-apiversion-upgrade

/test pull-cluster-api-provider-azure-build

/test pull-cluster-api-provider-azure-ci-entrypoint

/test pull-cluster-api-provider-azure-e2e

/test pull-cluster-api-provider-azure-e2e-aks

/test pull-cluster-api-provider-azure-test

/test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-azure-apidiff

/test pull-cluster-api-provider-azure-apiserver-ilb

/test pull-cluster-api-provider-azure-capi-e2e

/test pull-cluster-api-provider-azure-conformance

/test pull-cluster-api-provider-azure-conformance-custom-builds

/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

/test pull-cluster-api-provider-azure-e2e-optional

/test pull-cluster-api-provider-azure-e2e-workload-upgrade

/test pull-cluster-api-provider-azure-load-test-custom-builds

/test pull-cluster-api-provider-azure-windows-custom-builds

/test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-azure-apidiff

pull-cluster-api-provider-azure-build

pull-cluster-api-provider-azure-ci-entrypoint

pull-cluster-api-provider-azure-conformance

pull-cluster-api-provider-azure-conformance-custom-builds

pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts

pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts

pull-cluster-api-provider-azure-conformance-with-ci-artifacts

pull-cluster-api-provider-azure-conformance-with-ci-artifacts-dra

pull-cluster-api-provider-azure-e2e

pull-cluster-api-provider-azure-e2e-aks

pull-cluster-api-provider-azure-test

pull-cluster-api-provider-azure-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@willie-yao
Copy link
Contributor

/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-e2e-workload-upgrade

@nawazkh
Copy link
Member Author

nawazkh commented Mar 20, 2025

/test pull-cluster-api-provider-azure-e2e

@nawazkh
Copy link
Member Author

nawazkh commented Mar 20, 2025

Looks like a flake since first occurrence of pull-cluster-api-provider-azure-e2e failed on waiting for 1/2 windows instances and the second one failed on waiting for 0/2 instances.

/test pull-cluster-api-provider-azure-e2e

@nawazkh
Copy link
Member Author

nawazkh commented Mar 20, 2025

Flake again.. Not sure if I should increase the timeout for pull-cluster-api-provider-azure-e2e ? One last try before attempting to increase the timeout.
/retest

@k8s-ci-robot k8s-ci-robot merged commit f0f36c7 into kubernetes-sigs:main Mar 21, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 21, 2025
@nawazkh nawazkh deleted the increase_kubeadm_verbosity branch April 4, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

@marosset marosset Awaiting requested review from marosset

Assignees

@Jont828 Jont828

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nawazkh @k8s-ci-robot @willie-yao @Jont828