Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Otel packages to v1.35.0 | Prometheus to v1.57.0 #5479

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Mar 10, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • Updated Otel dependencies to v1.35.0
  • Updates Prometheus to v1.57.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Update Otel and related dependencies to v1.35.0

dependabot bot and others added 2 commits March 10, 2025 13:29
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.34.0 to 1.35.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.34.0...v1.35.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2025
@nawazkh
Copy link
Member Author

nawazkh commented Mar 10, 2025

Hey @mboersma , apart from checking the release notes and update the Prometheus dep version, what else could be checking to make sure I got the right dep version upgrade ?
Should we be updating prometheus to v0.62.0 as seen in this diff open-telemetry/opentelemetry-go@v1.34.0...v1.35.0#diff-20b6379656bb9f3f2b9aa48000f66b7327be916177a2eb83a2d7174c16be97b1 ?

/assign @mboersma

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (a5f0307) to head (7e49cab).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5479      +/-   ##
==========================================
+ Coverage   52.56%   52.57%   +0.01%     
==========================================
  Files         272      272              
  Lines       29423    29468      +45     
==========================================
+ Hits        15465    15493      +28     
- Misses      13151    13167      +16     
- Partials      807      808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh nawazkh changed the title Nhk bump otel Bump Otel packages to v1.35.0| Prometheus to v1.57.0 Mar 11, 2025
@nawazkh nawazkh changed the title Bump Otel packages to v1.35.0| Prometheus to v1.57.0 Bump Otel packages to v1.35.0 | Prometheus to v1.57.0 Mar 11, 2025
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4929cc179a23555ee1da8df6bfd6c60b49a279bc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0ebc1f4 into kubernetes-sigs:main Mar 11, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 11, 2025
@nawazkh nawazkh deleted the nhk_bump-otel branch March 11, 2025 19:15
@mboersma
Copy link
Contributor

what else could be checking to make sure I got the right dep version upgrade

@nawazkh sorry I missed this until now! Looks good to me, it's mostly a question of updating go.mod in sync as you did. 👍🏻 We used to update the embedded Helm chart, but we've drifted pretty far away from the current one and I think it would be some work to reconcile them (and the current one still works so far).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants